iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: get rid of greybus_gbuf_finished()

Browse Source 
All greybus_gbuf_finished() does is call the gbuf's complete method.
Currently, greybus_gbuf_finished() is only ever called in one place,
and that place can call the complete method directly instead.  That
allows us to eliminate greybus_gbuf_finished().

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Alex Elder 2014-11-06 07:01:04 -06:00 committed by Greg Kroah-Hartman
parent a77b06809b
commit eecf6deb57
3 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/greybus/gbuf.c
View File

@ -128,13 +128,6 @@ void greybus_cport_in(struct greybus_host_device *hd, u16 cport_id,
}
EXPORT_SYMBOL_GPL(greybus_cport_in);
/* Can be called in interrupt context, do the work and get out of here */
void greybus_gbuf_finished(struct gbuf *gbuf)
{
gbuf->complete(gbuf);
}
EXPORT_SYMBOL_GPL(greybus_gbuf_finished);
int gb_gbuf_init(void)
{
gbuf_head_cache = kmem_cache_create("gbuf_head_cache",

1
drivers/staging/greybus/greybus.h
View File

@ -191,7 +191,6 @@ struct greybus_host_device *greybus_create_hd(struct greybus_host_driver *hd,
void greybus_remove_hd(struct greybus_host_device *hd);
void greybus_cport_in(struct greybus_host_device *hd, u16 cport_id,
u8 *data, size_t length);
void greybus_gbuf_finished(struct gbuf *gbuf);
struct gbuf *greybus_alloc_gbuf(struct gb_operation *operation,
gbuf_complete_t complete, unsigned int size,

6
drivers/staging/greybus/operation.c
View File

@ -207,6 +207,7 @@ out:
static void gb_operation_recv_work(struct work_struct *recv_work)
{
struct gb_operation *operation;
struct gbuf *gbuf;
bool incoming_request;
operation = container_of(recv_work, struct gb_operation, recv_work);
@ -217,9 +218,10 @@ static void gb_operation_recv_work(struct work_struct *recv_work)
/* We're finished with the buffer we read into */
if (incoming_request)
greybus_gbuf_finished(operation->request);
gbuf = operation->request;
else
greybus_gbuf_finished(operation->response);
gbuf = operation->response;
gbuf->complete(gbuf);
}
/*