iio: adc: stm32-adc-core: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230919174931.1417681-21-u.kleine-koenig@pengutronix.de Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
parent
e785bace1a
commit
eedcd8c732
@ -819,7 +819,7 @@ err_pm_stop:
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int stm32_adc_remove(struct platform_device *pdev)
|
||||
static void stm32_adc_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct stm32_adc_common *common = platform_get_drvdata(pdev);
|
||||
struct stm32_adc_priv *priv = to_stm32_adc_priv(common);
|
||||
@ -831,8 +831,6 @@ static int stm32_adc_remove(struct platform_device *pdev)
|
||||
pm_runtime_disable(&pdev->dev);
|
||||
pm_runtime_set_suspended(&pdev->dev);
|
||||
pm_runtime_put_noidle(&pdev->dev);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int stm32_adc_core_runtime_suspend(struct device *dev)
|
||||
@ -913,7 +911,7 @@ MODULE_DEVICE_TABLE(of, stm32_adc_of_match);
|
||||
|
||||
static struct platform_driver stm32_adc_driver = {
|
||||
.probe = stm32_adc_probe,
|
||||
.remove = stm32_adc_remove,
|
||||
.remove_new = stm32_adc_remove,
|
||||
.driver = {
|
||||
.name = "stm32-adc-core",
|
||||
.of_match_table = stm32_adc_of_match,
|
||||
|
Loading…
x
Reference in New Issue
Block a user