iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ovl: fix uninitialized pointer read in ovl_lookup_real_one()

Browse Source 
[ Upstream commit 580c610429 ]

One error path can result in release_dentry_name_snapshot() being called
before "name" was initialized by take_dentry_name_snapshot().

Fix by moving the release_dentry_name_snapshot() to immediately after the
only use.

Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Miklos Szeredi
2021-08-06 10:03:12 +02:00
committed by Greg Kroah-Hartman
parent c94d50979f
commit ef2d68ef9a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fs/overlayfs/export.c
View File

@ -390,6 +390,7 @@ static struct dentry *ovl_lookup_real_one(struct dentry *connected,
*/ */
take_dentry_name_snapshot(&name, real); take_dentry_name_snapshot(&name, real);
this = lookup_one_len(name.name.name, connected, name.name.len); this = lookup_one_len(name.name.name, connected, name.name.len);
release_dentry_name_snapshot(&name);
err = PTR_ERR(this); err = PTR_ERR(this);
if (IS_ERR(this)) { if (IS_ERR(this)) {
goto fail; goto fail;
@ -404,7 +405,6 @@ static struct dentry *ovl_lookup_real_one(struct dentry *connected,
} }
out: out:
release_dentry_name_snapshot(&name);
dput(parent); dput(parent);
inode_unlock(dir); inode_unlock(dir);
return this; return this;