iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix array-index-out-of-bounds in taprio_change

Browse Source 
syzbot report an array-index-out-of-bounds in taprio_change
index 16 is out of range for type '__u16 [16]'
that's because mqprio->num_tc is lager than TC_MAX_QUEUE,so we check
the return value of netdev_set_num_tc.

Reported-by: syzbot+2b3e5fb6c7ef285a94f6@syzkaller.appspotmail.com
Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Haimin Zhang 2021-08-30 11:47:01 +08:00 committed by David S. Miller
parent e842cb60e8
commit efe487fce3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/sched/sch_taprio.c
View File

@ -1513,7 +1513,9 @@ static int taprio_change(struct Qdisc *sch, struct nlattr *opt,
taprio_set_picos_per_byte(dev, q); taprio_set_picos_per_byte(dev, q);
if (mqprio) { if (mqprio) {
netdev_set_num_tc(dev, mqprio->num_tc); err = netdev_set_num_tc(dev, mqprio->num_tc);
if (err)
goto free_sched;
for (i = 0; i < mqprio->num_tc; i++) for (i = 0; i < mqprio->num_tc; i++)
netdev_set_tc_queue(dev, i, netdev_set_tc_queue(dev, i,
mqprio->count[i], mqprio->count[i],