iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iwlwifi: release IRQ in error path

Browse Source 
smatch correctly complains:
iwl-trans-pcie.c +1528 iwl_trans_pcie_start_hw(50) warn: 'trans->irq' was not released on error

Fix it.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Wey-Yi W Guy <wey-yi.w.guy@intel.com>
This commit is contained in:
Johannes Berg 2012-01-29 18:36:01 -08:00 committed by Wey-Yi Guy
parent edf3833406
commit f057ac4ed7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireless/iwlwifi/iwl-trans-pcie.c
View File

@ -1504,7 +1504,7 @@ static int iwl_trans_pcie_start_hw(struct iwl_trans *trans)
err = iwl_prepare_card_hw(trans); err = iwl_prepare_card_hw(trans);
if (err) { if (err) {
IWL_ERR(trans, "Error while preparing HW: %d", err); IWL_ERR(trans, "Error while preparing HW: %d", err);
goto error; goto err_free_irq;
} }
iwl_apm_init(trans); iwl_apm_init(trans);
@ -1522,6 +1522,8 @@ static int iwl_trans_pcie_start_hw(struct iwl_trans *trans)
return err; return err;
err_free_irq:
free_irq(trans->irq, trans);
error: error:
iwl_free_isr_ict(trans); iwl_free_isr_ict(trans);
tasklet_kill(&trans_pcie->irq_tasklet); tasklet_kill(&trans_pcie->irq_tasklet);