iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: imx274: remove unused data from struct imx274_frmfmt

Browse Source 
struct imx274_frmfmt is instantiated only in the imx274_formats[]
array, where imx274_formats[N].mode always equals N (via enum
imx274_mode).  So .mode carries no information, and unsurprisingly it
is never used.

mbus_code is never used because the 12 bit modes are not implemented.

The colorspace member is also never used, which is normal since the
imx274 sensor can output only one colorspace.

Let's get rid of all of them.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Luca Ceresoli 2018-04-24 04:24:09 -04:00 committed by Mauro Carvalho Chehab
parent cf90870454
commit f067ddad00
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/media/i2c/imx274.c
View File

@ -156,10 +156,7 @@ enum imx274_mode {
* imx274 format related structure
*/
struct imx274_frmfmt {
u32 mbus_code;
enum v4l2_colorspace colorspace;
struct v4l2_frmsize_discrete size;
enum imx274_mode mode;
};
/*
@ -501,12 +498,9 @@ static const struct reg_8 *mode_table[] = {
* imx274 format related structure
*/
static const struct imx274_frmfmt imx274_formats[] = {
{MEDIA_BUS_FMT_SRGGB10_1X10, V4L2_COLORSPACE_SRGB, {3840, 2160},
IMX274_MODE_3840X2160},
{MEDIA_BUS_FMT_SRGGB10_1X10, V4L2_COLORSPACE_SRGB, {1920, 1080},
IMX274_MODE_1920X1080},
{MEDIA_BUS_FMT_SRGGB10_1X10, V4L2_COLORSPACE_SRGB, {1280, 720},
IMX274_MODE_1280X720},
{ {3840, 2160} },
{ {1920, 1080} },
{ {1280, 720} },
};
/*
@ -890,9 +884,8 @@ static int imx274_set_fmt(struct v4l2_subdev *sd,
int index;
dev_dbg(&client->dev,
"%s: width = %d height = %d code = %d mbus_code = %d\n",
__func__, fmt->width, fmt->height, fmt->code,
imx274_formats[imx274->mode_index].mbus_code);
"%s: width = %d height = %d code = %d\n",
__func__, fmt->width, fmt->height, fmt->code);
mutex_lock(&imx274->lock);