iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

x86/mm: fix poking_init() for Xen PV guests

Browse Source 
commit 26ce6ec364 upstream.

Commit 3f4c8211d9 ("x86/mm: Use mm_alloc() in poking_init()") broke
the kernel for running as Xen PV guest.

It seems as if the new address space is never activated before being
used, resulting in Xen rejecting to accept the new CR3 value (the PGD
isn't pinned).

Fix that by adding the now missing call of paravirt_arch_dup_mmap() to
poking_init(). That call was previously done by dup_mm()->dup_mmap() and
it is a NOP for all cases but for Xen PV, where it is just doing the
pinning of the PGD.

Fixes: 3f4c8211d9 ("x86/mm: Use mm_alloc() in poking_init()")
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20230109150922.10578-1-jgross@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Juergen Gross
2023-01-09 16:09:22 +01:00
committed by Greg Kroah-Hartman
parent 583016037a
commit f076d08178
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
arch/x86/mm/init.c
View File

@ -27,6 +27,7 @@
#include <asm/pti.h> #include <asm/pti.h>
#include <asm/text-patching.h> #include <asm/text-patching.h>
#include <asm/memtype.h> #include <asm/memtype.h>
#include <asm/paravirt.h>
/* /*
* We need to define the tracepoints somewhere, and tlb.c * We need to define the tracepoints somewhere, and tlb.c
@ -807,6 +808,9 @@ void __init poking_init(void)
poking_mm = copy_init_mm(); poking_mm = copy_init_mm();
BUG_ON(!poking_mm); BUG_ON(!poking_mm);
/* Xen PV guests need the PGD to be pinned. */
paravirt_arch_dup_mmap(NULL, poking_mm);
/* /*
* Randomize the poking address, but make sure that the following page * Randomize the poking address, but make sure that the following page
* will be mapped at the same PMD. We need 2 pages, so find space for 3, * will be mapped at the same PMD. We need 2 pages, so find space for 3,