New code for 5.5:
- Fix another place in the splice code where a pipe could ask a filesystem for a longer read than the pipe actually has free buffer space. -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEUzaAxoMeQq6m2jMV+H93GTRKtOsFAl3XKBsACgkQ+H93GTRK tOubhg/9FhWIX+Ijj0a1MQj3QDv0YbLPv2uTVLYyRK+1X5Xwc7u0OmmbWYrQQQUJ 6aOaictBXXTIJtKqVcmXBXboUskKygnWKlVssKAI/BYR9ope/EMrMV5+4bz0mKt/ ufcDXRiJX2hbL8GicmJxK/qmp3bEAG0n/e0+0LcuYynatYXJQ19eOUeritVZ3EYA Vhbgvrtuq8ws9SqvJ4Dm7fLsPT0AOHocor34tXS+gRq8KYIA2Ru7uDyE2uJJujF7 qAlmZVvun+RcSBG0mYdk6GDgLGibn76t+d0xnqd/OzSeh+6bHYc1ni6FJD8kjVzf nGHFJfbEOCzDEees9ESBkgnH1TiCN4wCs7JQ4BictAPotBCtkbcNLvrO+b77zgwp DAu6uE/DiRmIu9zqfy8TyH1E78pW7qTpI9yFDUQLaItvAbbqYIaiRLr4Hjd2Hf3E MLYOSGZkKn/xZaqedk+rGwYJJmmvzCZblfrQ3hCtLGjmNQgfTRXidlgyicl1Ta12 iG9UkCFdbkZmdW9zWyYmZrfxLB6QzOZpgbdUwyMk0Rfc1sKJKYoNE+hkt8fjmS71 0hBPYSopDsYkGEH1719Nsfvyj0101McFklvEqS2hU9/rLyaF0Mdq5catVbzyBPhk RwnvXdFd/sFgbR+1xLiEm51aXAe/kmveNNQBqZkuBgXITt7oh7Q= =ripU -----END PGP SIGNATURE----- Merge tag 'vfs-5.5-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux Pull splice fix from Darrick Wong: "Fix another place in the splice code where a pipe could ask a filesystem for a longer read than the pipe actually has free buffer space" * tag 'vfs-5.5-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux: splice: only read in as much information as there is pipe buffer space
This commit is contained in:
commit
f112a2fd1f
14
fs/splice.c
14
fs/splice.c
@ -945,12 +945,13 @@ ssize_t splice_direct_to_actor(struct file *in, struct splice_desc *sd,
|
||||
WARN_ON_ONCE(pipe->nrbufs != 0);
|
||||
|
||||
while (len) {
|
||||
unsigned int pipe_pages;
|
||||
size_t read_len;
|
||||
loff_t pos = sd->pos, prev_pos = pos;
|
||||
|
||||
/* Don't try to read more the pipe has space for. */
|
||||
read_len = min_t(size_t, len,
|
||||
(pipe->buffers - pipe->nrbufs) << PAGE_SHIFT);
|
||||
pipe_pages = pipe->buffers - pipe->nrbufs;
|
||||
read_len = min(len, (size_t)pipe_pages << PAGE_SHIFT);
|
||||
ret = do_splice_to(in, &pos, pipe, read_len, flags);
|
||||
if (unlikely(ret <= 0))
|
||||
goto out_release;
|
||||
@ -1180,8 +1181,15 @@ static long do_splice(struct file *in, loff_t __user *off_in,
|
||||
|
||||
pipe_lock(opipe);
|
||||
ret = wait_for_space(opipe, flags);
|
||||
if (!ret)
|
||||
if (!ret) {
|
||||
unsigned int pipe_pages;
|
||||
|
||||
/* Don't try to read more the pipe has space for. */
|
||||
pipe_pages = opipe->buffers - opipe->nrbufs;
|
||||
len = min(len, (size_t)pipe_pages << PAGE_SHIFT);
|
||||
|
||||
ret = do_splice_to(in, &offset, opipe, len, flags);
|
||||
}
|
||||
pipe_unlock(opipe);
|
||||
if (ret > 0)
|
||||
wakeup_pipe_readers(opipe);
|
||||
|
Loading…
Reference in New Issue
Block a user