iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phy: exynos5-usbdrd: make phy_isol() take a bool for clarity

Browse Source 
on / not on is just a boolean flag and is a bit misleading as currently
on==1 means to turn off the power, and on==0 to turn power on.

Rename the flag and make it a bool to avoid confusion of future readers
of this code. No functional change.

While at it, fix a whitespace issue in nearby comment.

No functional change.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240507-samsung-usb-phy-fixes-v1-3-4ccba5afa7cc@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
André Draszik 2024-05-07 15:14:46 +01:00 committed by Vinod Koul
parent 27f3d3f6d8
commit f2b6fc4d5c
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/phy/samsung/phy-exynos5-usbdrd.c
View File

@ -173,7 +173,7 @@ struct exynos5_usbdrd_phy;
struct exynos5_usbdrd_phy_config { struct exynos5_usbdrd_phy_config {
u32 id; u32 id;
void (*phy_isol)(struct phy_usb_instance *inst, u32 on); void (*phy_isol)(struct phy_usb_instance *inst, bool isolate);
void (*phy_init)(struct exynos5_usbdrd_phy *phy_drd); void (*phy_init)(struct exynos5_usbdrd_phy *phy_drd);
unsigned int (*set_refclk)(struct phy_usb_instance *inst); unsigned int (*set_refclk)(struct phy_usb_instance *inst);
}; };
@ -273,14 +273,14 @@ static unsigned int exynos5_rate_to_clk(unsigned long rate, u32 *reg)
} }
static void exynos5_usbdrd_phy_isol(struct phy_usb_instance *inst, static void exynos5_usbdrd_phy_isol(struct phy_usb_instance *inst,
unsigned int on) bool isolate)
{ {
unsigned int val; unsigned int val;
if (!inst->reg_pmu) if (!inst->reg_pmu)
return; return;
val = on ? 0 : EXYNOS4_PHY_ENABLE; val = isolate ? 0 : EXYNOS4_PHY_ENABLE;
regmap_update_bits(inst->reg_pmu, inst->pmu_offset, regmap_update_bits(inst->reg_pmu, inst->pmu_offset,
EXYNOS4_PHY_ENABLE, val); EXYNOS4_PHY_ENABLE, val);
@ -525,8 +525,8 @@ static int exynos5_usbdrd_phy_power_on(struct phy *phy)
} }
} }
/* Power-on PHY*/ /* Power-on PHY */
inst->phy_cfg->phy_isol(inst, 0); inst->phy_cfg->phy_isol(inst, false);
return 0; return 0;
@ -553,7 +553,7 @@ static int exynos5_usbdrd_phy_power_off(struct phy *phy)
dev_dbg(phy_drd->dev, "Request to power_off usbdrd_phy phy\n"); dev_dbg(phy_drd->dev, "Request to power_off usbdrd_phy phy\n");
/* Power-off the PHY */ /* Power-off the PHY */
inst->phy_cfg->phy_isol(inst, 1); inst->phy_cfg->phy_isol(inst, true);
/* Disable VBUS supply */ /* Disable VBUS supply */
if (phy_drd->vbus) if (phy_drd->vbus)