iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

USB: wusbcore: fix usb_dev leaks

Browse Source 
cbaf_probe() does cbaf->usb_dev = usb_get_dev(interface_to_usbdev(iface)),
but there is no usb_put_dev() anywhere in cbaf.

The patch adds usb_put_dev() to cbaf_disconnect() and to an error path in cbaf_probe().
Also it adds missed usb_put_intf(iface) to the error path.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alexey Khoroshilov 2013-10-19 01:49:38 +04:00 committed by Greg Kroah-Hartman
parent f7d4ffa923
commit f2c28cfc26
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/wusbcore/cbaf.c
View File

@ -623,6 +623,8 @@ static int cbaf_probe(struct usb_interface *iface,
error_create_group: error_create_group:
error_check: error_check:
usb_put_intf(iface);
usb_put_dev(cbaf->usb_dev);
kfree(cbaf->buffer); kfree(cbaf->buffer);
error_kmalloc_buffer: error_kmalloc_buffer:
kfree(cbaf); kfree(cbaf);
@ -637,6 +639,7 @@ static void cbaf_disconnect(struct usb_interface *iface)
sysfs_remove_group(&dev->kobj, &cbaf_dev_attr_group); sysfs_remove_group(&dev->kobj, &cbaf_dev_attr_group);
usb_set_intfdata(iface, NULL); usb_set_intfdata(iface, NULL);
usb_put_intf(iface); usb_put_intf(iface);
usb_put_dev(cbaf->usb_dev);
kfree(cbaf->buffer); kfree(cbaf->buffer);
/* paranoia: clean up crypto keys */ /* paranoia: clean up crypto keys */
kzfree(cbaf); kzfree(cbaf);