iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fs/cifs: fix gcc warning in sid_to_id

Browse Source 
fix warning [-Wunused-but-set-variable] at variable 'rc',
keeping the code readable.

Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Qiujun Huang 2020-03-04 15:42:51 +08:00 committed by Steve French
parent 0667059d0b
commit f2d67931fd
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/cifs/cifsacl.c
View File

@ -342,7 +342,7 @@ static int
sid_to_id(struct cifs_sb_info *cifs_sb, struct cifs_sid *psid, sid_to_id(struct cifs_sb_info *cifs_sb, struct cifs_sid *psid,
struct cifs_fattr *fattr, uint sidtype) struct cifs_fattr *fattr, uint sidtype)
{ {
int rc; int rc = 0;
struct key *sidkey; struct key *sidkey;
char *sidstr; char *sidstr;
const struct cred *saved_cred; const struct cred *saved_cred;
@ -450,11 +450,12 @@ out_revert_creds:
* fails then we just fall back to using the mnt_uid/mnt_gid. * fails then we just fall back to using the mnt_uid/mnt_gid.
*/ */
got_valid_id: got_valid_id:
rc = 0;
if (sidtype == SIDOWNER) if (sidtype == SIDOWNER)
fattr->cf_uid = fuid; fattr->cf_uid = fuid;
else else
fattr->cf_gid = fgid; fattr->cf_gid = fgid;
return 0; return rc;
} }
int int