rtc: ds1511: drop useless checks
The RTC core will always pass a valid rtc_tm, it is unnecessary to check the validity of its members, especially with an open coded version of rtc_valid_tm(). Link: https://lore.kernel.org/r/20240227230431.1837717-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
parent
6613476e22
commit
f4282a4303
@ -182,9 +182,6 @@ static int ds1511_rtc_set_time(struct device *dev, struct rtc_time *rtc_tm)
|
||||
if (rtc_tm->tm_year < 1900)
|
||||
rtc_tm->tm_year += 1900;
|
||||
|
||||
if (rtc_tm->tm_year < 1970)
|
||||
return -EINVAL;
|
||||
|
||||
yrs = rtc_tm->tm_year % 100;
|
||||
cen = rtc_tm->tm_year / 100;
|
||||
mon = rtc_tm->tm_mon + 1; /* tm_mon starts at zero */
|
||||
@ -194,15 +191,6 @@ static int ds1511_rtc_set_time(struct device *dev, struct rtc_time *rtc_tm)
|
||||
min = rtc_tm->tm_min;
|
||||
sec = rtc_tm->tm_sec;
|
||||
|
||||
if ((mon > 12) || (day == 0))
|
||||
return -EINVAL;
|
||||
|
||||
if (day > rtc_month_days(rtc_tm->tm_mon, rtc_tm->tm_year))
|
||||
return -EINVAL;
|
||||
|
||||
if ((hrs >= 24) || (min >= 60) || (sec >= 60))
|
||||
return -EINVAL;
|
||||
|
||||
/*
|
||||
* each register is a different number of valid bits
|
||||
*/
|
||||
|
Loading…
x
Reference in New Issue
Block a user