checkpatch: add printk_once and printk_ratelimit to prefer pr_<level> warning
Add the _once and _ratelimited variants to the test for printk(KERN_<LEVEL> that should prefer pr_<level>. Miscellanea: o Add comment description for the conversions [joe@perches.com: fixlet] Link: https://lkml.kernel.org/r/32260871d4718ba7f48a8e9e07452bb76de300db.camel@perches.comLink: https://lkml.kernel.org/r/993b72b2ef91a57c5e725b52971ce3fd31375061.camel@perches.com Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
7da07c31b1
commit
f5eea3b044
@ -4543,16 +4543,23 @@ sub process {
|
||||
"printk() should include KERN_<LEVEL> facility level\n" . $herecurr);
|
||||
}
|
||||
|
||||
if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) {
|
||||
my $orig = $1;
|
||||
# prefer variants of (subsystem|netdev|dev|pr)_<level> to printk(KERN_<LEVEL>
|
||||
if ($line =~ /\b(printk(_once|_ratelimited)?)\s*\(\s*KERN_([A-Z]+)/) {
|
||||
my $printk = $1;
|
||||
my $modifier = $2;
|
||||
my $orig = $3;
|
||||
$modifier = "" if (!defined($modifier));
|
||||
my $level = lc($orig);
|
||||
$level = "warn" if ($level eq "warning");
|
||||
my $level2 = $level;
|
||||
$level2 = "dbg" if ($level eq "debug");
|
||||
$level .= $modifier;
|
||||
$level2 .= $modifier;
|
||||
WARN("PREFER_PR_LEVEL",
|
||||
"Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr);
|
||||
"Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to $printk(KERN_$orig ...\n" . $herecurr);
|
||||
}
|
||||
|
||||
# prefer dev_<level> to dev_printk(KERN_<LEVEL>
|
||||
if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
|
||||
my $orig = $1;
|
||||
my $level = lc($orig);
|
||||
|
Loading…
Reference in New Issue
Block a user