iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ata: libahci: Use of_platform_device_create only if supported

Browse Source 
of_platform_device_create does not exist if OF_ADDRESS is not configured,
so limit its use accordingly.

Without this fix, the sparc64:allmodconfig build fails with

ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined!

Fixes: c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators")
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
Guenter Roeck 2015-01-31 10:36:22 -08:00 committed by Tejun Heo
parent fad0601643
commit f627cfdeb7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/ata/libahci_platform.c
View File

@ -418,7 +418,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
if (child_nodes) { if (child_nodes) {
for_each_child_of_node(dev->of_node, child) { for_each_child_of_node(dev->of_node, child) {
u32 port; u32 port;
struct platform_device *port_dev; struct platform_device *port_dev __maybe_unused;
if (!of_device_is_available(child)) if (!of_device_is_available(child))
continue; continue;
@ -434,6 +434,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
} }
mask_port_map |= BIT(port); mask_port_map |= BIT(port);
#ifdef CONFIG_OF_ADDRESS
of_platform_device_create(child, NULL, NULL); of_platform_device_create(child, NULL, NULL);
port_dev = of_find_device_by_node(child); port_dev = of_find_device_by_node(child);
@ -444,6 +445,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
if (rc == -EPROBE_DEFER) if (rc == -EPROBE_DEFER)
goto err_out; goto err_out;
} }
#endif
rc = ahci_platform_get_phy(hpriv, port, dev, child); rc = ahci_platform_get_phy(hpriv, port, dev, child);
if (rc) if (rc)