iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ksmbd: Replace the ternary conditional operator with min()

Browse Source 
It would be better to replace the traditional ternary conditional
operator with min() in compare_sids.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Lu Hongfei 2023-06-09 13:06:36 +08:00 committed by Steve French
parent 81a94b2784
commit f65fadb042
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/smb/server/smbacl.c
View File

@ -97,7 +97,7 @@ int compare_sids(const struct smb_sid *ctsid, const struct smb_sid *cwsid)
/* compare all of the subauth values if any */ /* compare all of the subauth values if any */
num_sat = ctsid->num_subauth; num_sat = ctsid->num_subauth;
num_saw = cwsid->num_subauth; num_saw = cwsid->num_subauth;
num_subauth = num_sat < num_saw ? num_sat : num_saw; num_subauth = min(num_sat, num_saw);
if (num_subauth) { if (num_subauth) {
for (i = 0; i < num_subauth; ++i) { for (i = 0; i < num_subauth; ++i) {
if (ctsid->sub_auth[i] != cwsid->sub_auth[i]) { if (ctsid->sub_auth[i] != cwsid->sub_auth[i]) {