iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm/msync: exit early when the flags is an MS_ASYNC and start < vm_start

Browse Source 
If an unmapped region was found and the flag is MS_ASYNC (without
MS_INVALIDATE) there is nothing to do and the result would be always
-ENOMEM, so return immediately.

Link: https://lkml.kernel.org/r/20201025092901.56399-1-sh1r4s3@mail.si-head.nl
Signed-off-by: Nikita Ermakov <sh1r4s3@mail.si-head.nl>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Nikita Ermakov 2021-04-29 22:55:41 -07:00 committed by Linus Torvalds
parent 4b17f030fd
commit f6899bc03c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mm/msync.c
View File

@ -55,7 +55,9 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags)
goto out; goto out;
/* /*
* If the interval [start,end) covers some unmapped address ranges, * If the interval [start,end) covers some unmapped address ranges,
* just ignore them, but return -ENOMEM at the end. * just ignore them, but return -ENOMEM at the end. Besides, if the
* flag is MS_ASYNC (w/o MS_INVALIDATE) the result would be -ENOMEM
* anyway and there is nothing left to do, so return immediately.
*/ */
mmap_read_lock(mm); mmap_read_lock(mm);
vma = find_vma(mm, start); vma = find_vma(mm, start);
@ -69,6 +71,8 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags)
goto out_unlock; goto out_unlock;
/* Here start < vma->vm_end. */ /* Here start < vma->vm_end. */
if (start < vma->vm_start) { if (start < vma->vm_start) {
if (flags == MS_ASYNC)
goto out_unlock;
start = vma->vm_start; start = vma->vm_start;
if (start >= end) if (start >= end)
goto out_unlock; goto out_unlock;