iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iio: pressure: ms5611: Make ms5611_remove() return void

Browse Source 
Up to now ms5611_remove() returns zero unconditionally. Make it return
void instead which makes it easier to see in the callers that there is
no error to handle.

Also the return value of i2c and spi remove callbacks is ignored anyway.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Link: https://lore.kernel.org/r/20211013203223.2694577-16-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Uwe Kleine-König 2021-10-13 22:32:23 +02:00 committed by Jonathan Cameron
parent 6dcfe3fe93
commit f840cbed7a
4 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/iio/pressure/ms5611.h
View File

@ -61,6 +61,6 @@ struct ms5611_state {
int ms5611_probe(struct iio_dev *indio_dev, struct device *dev,
const char *name, int type);
int ms5611_remove(struct iio_dev *indio_dev);
void ms5611_remove(struct iio_dev *indio_dev);
#endif /* _MS5611_H */

4
drivers/iio/pressure/ms5611_core.c
View File

@ -474,13 +474,11 @@ err_fini:
}
EXPORT_SYMBOL(ms5611_probe);
int ms5611_remove(struct iio_dev *indio_dev)
void ms5611_remove(struct iio_dev *indio_dev)
{
iio_device_unregister(indio_dev);
iio_triggered_buffer_cleanup(indio_dev);
ms5611_fini(indio_dev);
return 0;
}
EXPORT_SYMBOL(ms5611_remove);

4
drivers/iio/pressure/ms5611_i2c.c
View File

@ -110,7 +110,9 @@ static int ms5611_i2c_probe(struct i2c_client *client,
static int ms5611_i2c_remove(struct i2c_client *client)
{
return ms5611_remove(i2c_get_clientdata(client));
ms5611_remove(i2c_get_clientdata(client));
return 0;
}
static const struct of_device_id ms5611_i2c_matches[] = {

4
drivers/iio/pressure/ms5611_spi.c
View File

@ -112,7 +112,9 @@ static int ms5611_spi_probe(struct spi_device *spi)
static int ms5611_spi_remove(struct spi_device *spi)
{
return ms5611_remove(spi_get_drvdata(spi));
ms5611_remove(spi_get_drvdata(spi));
return 0;
}
static const struct of_device_id ms5611_spi_matches[] = {