iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ceph: fix a NULL vs IS_ERR() check when calling ceph_lookup_inode()

Browse Source 
The ceph_lookup_inode() function returns error pointers.  It never
returns NULL.

Fixes: aa87052dd965 ("ceph: fix incorrectly showing the .snap size for stat")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Dan Carpenter 2022-10-14 12:36:53 +03:00 committed by Ilya Dryomov
parent 3a4e894f36
commit f86a48667b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/ceph/inode.c
View File

@ -2492,7 +2492,7 @@ int ceph_getattr(struct user_namespace *mnt_userns, const struct path *path,
struct inode *parent; struct inode *parent;
parent = ceph_lookup_inode(sb, ceph_ino(inode)); parent = ceph_lookup_inode(sb, ceph_ino(inode));
if (!parent) if (IS_ERR(parent))
return PTR_ERR(parent); return PTR_ERR(parent);
pci = ceph_inode(parent); pci = ceph_inode(parent);