iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pwm: rockchip: Remove the judge from return value of pwm_config()

Browse Source 
It seems the rockchip_pwm_config() always returns the result 0, so
remove the judge.

Signed-off-by: David Wu <david.wu@rock-chips.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
David Wu 2017-08-08 23:38:30 +08:00 committed by Thierry Reding
parent 27922ff598
commit f90df9cda6
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/pwm/pwm-rockchip.c
View File

@ -165,7 +165,7 @@ static void rockchip_pwm_get_state(struct pwm_chip *chip,
clk_disable(pc->pclk); clk_disable(pc->pclk);
} }
static int rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, static void rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
int duty_ns, int period_ns) int duty_ns, int period_ns)
{ {
struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip); struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
@ -188,8 +188,6 @@ static int rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
writel(period, pc->base + pc->data->regs.period); writel(period, pc->base + pc->data->regs.period);
writel(duty, pc->base + pc->data->regs.duty); writel(duty, pc->base + pc->data->regs.duty);
return 0;
} }
static int rockchip_pwm_enable(struct pwm_chip *chip, static int rockchip_pwm_enable(struct pwm_chip *chip,
@ -236,13 +234,7 @@ static int rockchip_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
enabled = false; enabled = false;
} }
ret = rockchip_pwm_config(chip, pwm, state->duty_cycle, state->period); rockchip_pwm_config(chip, pwm, state->duty_cycle, state->period);
if (ret) {
if (enabled != curstate.enabled)
rockchip_pwm_enable(chip, pwm, !enabled,
state->polarity);
goto out;
}
if (state->enabled != enabled) { if (state->enabled != enabled) {
ret = rockchip_pwm_enable(chip, pwm, state->enabled, ret = rockchip_pwm_enable(chip, pwm, state->enabled,