iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ovl: use kvalloc in xattr copy-up

Browse Source 
Extended attributes are usually small, but could be up to 64k in size, so
use the most efficient method for doing the allocation.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
This commit is contained in:
Miklos Szeredi 2021-07-22 14:18:14 +02:00
parent d8991e8622
commit f945ca1963
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/overlayfs/copy_up.c
View File

@ -63,7 +63,7 @@ int ovl_copy_xattr(struct super_block *sb, struct dentry *old,
return list_size;
}
buf = kzalloc(list_size, GFP_KERNEL);
buf = kvzalloc(list_size, GFP_KERNEL);
if (!buf)
return -ENOMEM;
@ -106,11 +106,12 @@ retry:
if (size > value_size) {
void *new;
new = krealloc(value, size, GFP_KERNEL);
new = kvmalloc(size, GFP_KERNEL);
if (!new) {
error = -ENOMEM;
break;
}
kvfree(value);
value = new;
value_size = size;
goto retry;
@ -125,9 +126,9 @@ retry:
error = 0;
}
}
kfree(value);
kvfree(value);
out:
kfree(buf);
kvfree(buf);
return error;
}