iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Staging: rtlwifi: remove unnecessary NULL check

Browse Source 
The member regd of the struct rtl_priv is true in a boolean context.

drivers/staging/rtlwifi/regd.c:413:27: warning: address of 'rtlpriv->regd' will always
      evaluate to 'true' [-Wpointer-bool-conversion]
        if (!wiphy || !&rtlpriv->regd)
                      ~ ~~~~~~~~~^~~~
1 warning generated.

Link: https://github.com/ClangBuiltLinux/linux/issues/170

Signed-off-by: Karthik Nishanth <nishanthkarthik@live.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Karthik Nishanth 2018-09-22 14:23:54 +00:00 committed by Greg Kroah-Hartman
parent f007d901f2
commit f986978b32
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/rtlwifi/regd.c
View File

@ -410,7 +410,7 @@ int rtl_regd_init(struct ieee80211_hw *hw,
struct wiphy *wiphy = hw->wiphy; struct wiphy *wiphy = hw->wiphy;
struct country_code_to_enum_rd *country = NULL; struct country_code_to_enum_rd *country = NULL;
if (!wiphy || !&rtlpriv->regd) if (!wiphy)
return -EINVAL; return -EINVAL;
/* init country_code from efuse channel plan */ /* init country_code from efuse channel plan */