iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/v3d: cleanup BOs properly when lookup_bos fails

Browse Source 
When v3d_lookup_bos fails to `allocate validated BO pointers`,
job->bo_count was already set to args->bo_count, but job->bo points to
NULL. In this scenario, we must verify that job->bo is not NULL before
iterating on it to proper clean up a job. Also, drm_gem_object_put
already checks that the object passed is not NULL, doing the job->bo[i]
checker redundant.

Signed-off-by: Melissa Wen <mwen@igalia.com>
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221205135538.3545051-2-mwen@igalia.com
This commit is contained in:
Melissa Wen 2022-12-05 12:55:37 -01:00 committed by Melissa Wen
parent 4b6cb2b67d
commit f98c5ec251
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/v3d/v3d_gem.c
View File

@ -363,11 +363,11 @@ v3d_job_free(struct kref *ref)
struct v3d_job *job = container_of(ref, struct v3d_job, refcount);
int i;
for (i = 0; i < job->bo_count; i++) {
if (job->bo[i])
if (job->bo) {
for (i = 0; i < job->bo_count; i++)
drm_gem_object_put(job->bo[i]);
kvfree(job->bo);
}
kvfree(job->bo);
dma_fence_put(job->irq_fence);
dma_fence_put(job->done_fence);