iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

USB: otg/ulpi.c : fix register write

Browse Source 
ulpi_set_vbus and ulpi_set_flags are using ULPI_SET(register) to write
to the PHY's registers, which means we can only set bits in the PHY's
register and not clear them.
By directly using the address of the register without any offset, we
now get the expected behaviour for these functions.

Signed-off-by: Eric Bénard <eric@eukrea.com>
Cc: Daniel Mack <daniel@caiaq.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Sascha Hauer <kernel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Eric Bénard 2010-07-15 09:20:19 +02:00 committed by Greg Kroah-Hartman
parent 9800eb330d
commit fa345d0109
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/otg/ulpi.c
View File

@ -54,7 +54,7 @@ static int ulpi_set_flags(struct otg_transceiver *otg)
if (otg->flags & USB_OTG_EXT_VBUS_INDICATOR)
flags |= ULPI_OTG_CTRL_EXTVBUSIND;
return otg_io_write(otg, flags, ULPI_SET(ULPI_OTG_CTRL));
return otg_io_write(otg, flags, ULPI_OTG_CTRL);
}
static int ulpi_init(struct otg_transceiver *otg)
@ -95,7 +95,7 @@ static int ulpi_set_vbus(struct otg_transceiver *otg, bool on)
flags |= ULPI_OTG_CTRL_DRVVBUS_EXT;
}
return otg_io_write(otg, flags, ULPI_SET(ULPI_OTG_CTRL));
return otg_io_write(otg, flags, ULPI_OTG_CTRL);
}
struct otg_transceiver *