pinctrl: rza1: constify gpio_chip structure
This structure is only used to copy into other structure, so declare it as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; In the following log you can see a significant difference in the code size and data segment, hence in the dec segment. This log is the output of the size command, before and after the code change: before: text data bss dec hex filename 11866 3520 128 15514 3c9a drivers/pinctrl/pinctrl-rza1.o after: text data bss dec hex filename 11539 3464 128 15131 3b1b drivers/pinctrl/pinctrl-rza1.o Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
059b07989e
commit
fa39210d41
@ -723,7 +723,7 @@ static void rza1_gpio_set(struct gpio_chip *chip, unsigned int gpio,
|
|||||||
rza1_pin_set(port, gpio, value);
|
rza1_pin_set(port, gpio, value);
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct gpio_chip rza1_gpiochip_template = {
|
static const struct gpio_chip rza1_gpiochip_template = {
|
||||||
.request = rza1_gpio_request,
|
.request = rza1_gpio_request,
|
||||||
.free = rza1_gpio_free,
|
.free = rza1_gpio_free,
|
||||||
.get_direction = rza1_gpio_get_direction,
|
.get_direction = rza1_gpio_get_direction,
|
||||||
|
Loading…
Reference in New Issue
Block a user