iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sched: Simplify sched_move_task()

Browse Source 
Use guards to reduce gotos and simplify control flow.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Peter Zijlstra
2023-06-09 20:41:09 +02:00
committed by Ingo Molnar
parent af7c5763f5
commit fa614b4feb
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/sched/core.c
View File

@ -10437,17 +10437,18 @@ void sched_move_task(struct task_struct *tsk)
int queued, running, queue_flags = int queued, running, queue_flags =
DEQUEUE_SAVE | DEQUEUE_MOVE | DEQUEUE_NOCLOCK; DEQUEUE_SAVE | DEQUEUE_MOVE | DEQUEUE_NOCLOCK;
struct task_group *group; struct task_group *group;
struct rq_flags rf;
struct rq *rq; struct rq *rq;
rq = task_rq_lock(tsk, &rf); CLASS(task_rq_lock, rq_guard)(tsk);
rq = rq_guard.rq;
/* /*
* Esp. with SCHED_AUTOGROUP enabled it is possible to get superfluous * Esp. with SCHED_AUTOGROUP enabled it is possible to get superfluous
* group changes. * group changes.
*/ */
group = sched_get_task_group(tsk); group = sched_get_task_group(tsk);
if (group == tsk->sched_task_group) if (group == tsk->sched_task_group)
goto unlock; return;
update_rq_clock(rq); update_rq_clock(rq);
@ -10472,9 +10473,6 @@ void sched_move_task(struct task_struct *tsk)
*/ */
resched_curr(rq); resched_curr(rq);
} }
unlock:
task_rq_unlock(rq, tsk, &rf);
} }
static inline struct task_group *css_tg(struct cgroup_subsys_state *css) static inline struct task_group *css_tg(struct cgroup_subsys_state *css)