iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mmc: mediatek: Use mmc_regulator_set_vqmmc in start_signal_voltage_switch

Browse Source 
We've introduced a new helper in the MMC core:
mmc_regulator_set_vqmmc().  Let's use this in mtk-sd.  Using this new
helper has some advantages:

    1. We get the mmc_regulator_set_vqmmc() behavior of trying to match
       VQMMC and VMMC when the signal voltage is 3.3V.  This ensures max
       compatibility.

    2. We get rid of a few more warnings when probing unsupported
       voltages.

    3. We get rid of some non-mediatek specific code in mtk-sd.

Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Nicolas Boichat 2016-03-03 18:19:45 +08:00 committed by Ulf Hansson
parent f9bab9d2b1
commit fac49ce575
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/mmc/host/mtk-sd.c
View File

@ -1021,26 +1021,19 @@ static void msdc_set_buswidth(struct msdc_host *host, u32 width)
static int msdc_ops_switch_volt(struct mmc_host *mmc, struct mmc_ios *ios) static int msdc_ops_switch_volt(struct mmc_host *mmc, struct mmc_ios *ios)
{ {
struct msdc_host *host = mmc_priv(mmc); struct msdc_host *host = mmc_priv(mmc);
int min_uv, max_uv;
int ret = 0; int ret = 0;
if (!IS_ERR(mmc->supply.vqmmc)) { if (!IS_ERR(mmc->supply.vqmmc)) {
if (ios->signal_voltage == MMC_SIGNAL_VOLTAGE_330) { if (ios->signal_voltage != MMC_SIGNAL_VOLTAGE_330 &&
min_uv = 3300000; ios->signal_voltage != MMC_SIGNAL_VOLTAGE_180) {
max_uv = 3300000;
} else if (ios->signal_voltage == MMC_SIGNAL_VOLTAGE_180) {
min_uv = 1800000;
max_uv = 1800000;
} else {
dev_err(host->dev, "Unsupported signal voltage!\n"); dev_err(host->dev, "Unsupported signal voltage!\n");
return -EINVAL; return -EINVAL;
} }
ret = regulator_set_voltage(mmc->supply.vqmmc, min_uv, max_uv); ret = mmc_regulator_set_vqmmc(mmc, ios);
if (ret) { if (ret) {
dev_dbg(host->dev, dev_dbg(host->dev, "Regulator set error %d (%d)\n",
"Regulator set error %d: %d - %d\n", ret, ios->signal_voltage);
ret, min_uv, max_uv);
} else { } else {
/* Apply different pinctrl settings for different signal voltage */ /* Apply different pinctrl settings for different signal voltage */
if (ios->signal_voltage == MMC_SIGNAL_VOLTAGE_180) if (ios->signal_voltage == MMC_SIGNAL_VOLTAGE_180)