iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

evm: Use the metadata inode to calculate metadata hash

Browse Source 
Changes to file attributes (mode bits, uid, gid) on the lower layer are
not taken into account when d_backing_inode() is used when a file is
accessed on the overlay layer and this file has not yet been copied up.
This is because d_backing_inode() does not return the real inode of the
lower layer but instead returns the backing inode which in this case
holds wrong file attributes. Further, when CONFIG_OVERLAY_FS_METACOPY is
enabled and a copy-up is triggered due to file metadata changes, then
the metadata are held by the backing inode while the data are still held
by the real inode. Therefore, use d_inode(d_real(dentry, D_REAL_METADATA))
to get to the file's metadata inode and use it to calculate the metadata
hash with.

Co-developed-by: Mimi Zohar <zohar@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Acked-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
This commit is contained in:
Stefan Berger 2024-02-23 12:25:07 -05:00 committed by Mimi Zohar
parent f2b3fc42f6
commit faf994811e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
security/integrity/evm/evm_crypto.c
View File

@ -223,7 +223,7 @@ static int evm_calc_hmac_or_hash(struct dentry *dentry,
size_t req_xattr_value_len, size_t req_xattr_value_len,
uint8_t type, struct evm_digest *data) uint8_t type, struct evm_digest *data)
{ {
struct inode *inode = d_backing_inode(dentry); struct inode *inode = d_inode(d_real(dentry, D_REAL_METADATA));
struct xattr_list *xattr; struct xattr_list *xattr;
struct shash_desc *desc; struct shash_desc *desc;
size_t xattr_size = 0; size_t xattr_size = 0;