iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

batman-adv: use list_for_each_entry_safe

Browse Source 
Use list_for_each_entry_safe() instead of list_for_each_safe() to
simplify the code.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Antonio Quartulli <a@unstable.cc>
Reviewed-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
This commit is contained in:
Geliang Tang 2015-12-18 23:33:31 +08:00 committed by Antonio Quartulli
parent 925a6f3790
commit fb1f23eab6
1 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
net/batman-adv/icmp_socket.c
View File

@ -104,25 +104,21 @@ static int batadv_socket_open(struct inode *inode, struct file *file)
static int batadv_socket_release(struct inode *inode, struct file *file) static int batadv_socket_release(struct inode *inode, struct file *file)
{ {
struct batadv_socket_client *socket_client = file->private_data; struct batadv_socket_client *client = file->private_data;
struct batadv_socket_packet *socket_packet; struct batadv_socket_packet *packet, *tmp;
struct list_head *list_pos, *list_pos_tmp;
spin_lock_bh(&socket_client->lock); spin_lock_bh(&client->lock);
/* for all packets in the queue ... */ /* for all packets in the queue ... */
list_for_each_safe(list_pos, list_pos_tmp, &socket_client->queue_list) { list_for_each_entry_safe(packet, tmp, &client->queue_list, list) {
socket_packet = list_entry(list_pos, list_del(&packet->list);
struct batadv_socket_packet, list); kfree(packet);
list_del(list_pos);
kfree(socket_packet);
} }
batadv_socket_client_hash[socket_client->index] = NULL; batadv_socket_client_hash[client->index] = NULL;
spin_unlock_bh(&socket_client->lock); spin_unlock_bh(&client->lock);
kfree(socket_client); kfree(client);
module_put(THIS_MODULE); module_put(THIS_MODULE);
return 0; return 0;