iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sctp: remove the useless check in sctp_renege_events

Browse Source 
Remove the 'if (chunk)' check in sctp_renege_events for idata process,
as all renege commands are generated in sctp_eat_data and it can't be
NULL.

The same thing we already did for common data in sctp_ulpq_renege.

Fixes: 94014e8d87 ("sctp: implement renege_events for sctp_stream_interleave")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Xin Long 2018-02-12 18:31:24 +08:00 committed by David S. Miller
parent 947820b959
commit fb23403536
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
net/sctp/stream_interleave.c
View File

@ -954,12 +954,8 @@ static void sctp_renege_events(struct sctp_ulpq *ulpq, struct sctp_chunk *chunk,
__u32 freed = 0; __u32 freed = 0;
__u16 needed; __u16 needed;
if (chunk) { needed = ntohs(chunk->chunk_hdr->length) -
needed = ntohs(chunk->chunk_hdr->length); sizeof(struct sctp_idata_chunk);
needed -= sizeof(struct sctp_idata_chunk);
} else {
needed = SCTP_DEFAULT_MAXWINDOW;
}
if (skb_queue_empty(&asoc->base.sk->sk_receive_queue)) { if (skb_queue_empty(&asoc->base.sk->sk_receive_queue)) {
freed = sctp_ulpq_renege_list(ulpq, &ulpq->lobby, needed); freed = sctp_ulpq_renege_list(ulpq, &ulpq->lobby, needed);