iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V4L/DVB: stv0900: dereference of state->internal in fe_stv0900_error stv0900_init_internal()

Browse Source 
state->internal allocation may fail as well as the allocation of
stv0900_first_inode or new_node->next_inode in append_internal().

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Roel Kluin 2009-08-29 15:31:49 -03:00 committed by Mauro Carvalho Chehab
parent 6adb21c871
commit fb3ab105a5
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/dvb/frontends/stv0900_core.c
View File

@ -1384,7 +1384,14 @@ static enum fe_stv0900_error stv0900_init_internal(struct dvb_frontend *fe,
} else { } else {
state->internal = kmalloc(sizeof(struct stv0900_internal), state->internal = kmalloc(sizeof(struct stv0900_internal),
GFP_KERNEL); GFP_KERNEL);
if (state->internal == NULL)
return STV0900_INVALID_HANDLE;
temp_int = append_internal(state->internal); temp_int = append_internal(state->internal);
if (temp_int == NULL) {
kfree(state->internal);
state->internal = NULL;
return STV0900_INVALID_HANDLE;
}
state->internal->dmds_used = 1; state->internal->dmds_used = 1;
state->internal->i2c_adap = state->i2c_adap; state->internal->i2c_adap = state->i2c_adap;
state->internal->i2c_addr = state->config->demod_address; state->internal->i2c_addr = state->config->demod_address;