iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: software_node: Fix refcounts in software_node_get_next_child()

Browse Source 
The software_node_get_next_child() function currently does not hold
references to the child software_node that it finds or put the ref that
is held against the old child - fix that.

Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the firmware node framework")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Scally <djrscally@gmail.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Daniel Scally 2021-01-07 14:28:24 +01:00 committed by Mauro Carvalho Chehab
parent 54c261891c
commit fb5ec981ad
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/base/swnode.c
View File

@ -443,14 +443,18 @@ software_node_get_next_child(const struct fwnode_handle *fwnode,
struct swnode *c = to_swnode(child); struct swnode *c = to_swnode(child);
if (!p || list_empty(&p->children) || if (!p || list_empty(&p->children) ||
(c && list_is_last(&c->entry, &p->children))) (c && list_is_last(&c->entry, &p->children))) {
fwnode_handle_put(child);
return NULL; return NULL;
}
if (c) if (c)
c = list_next_entry(c, entry); c = list_next_entry(c, entry);
else else
c = list_first_entry(&p->children, struct swnode, entry); c = list_first_entry(&p->children, struct swnode, entry);
return &c->fwnode;
fwnode_handle_put(child);
return fwnode_handle_get(&c->fwnode);
} }
static struct fwnode_handle * static struct fwnode_handle *