iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/vmwgfx: Fix an incorrect lock check

Browse Source 
With CONFIG_SMP=n and CONFIG_DEBUG_SPINLOCK=y the vmwgfx kernel module
would unconditionally throw a bug when checking for a held spinlock
in the command buffer code. Fix this by using a lockdep check.

Cc: <stable@vger.kernel.org>
Reported-and-tested-by: Tetsuo Handa <penguin-kernel@i-love-sakura.ne.jp>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Thomas Hellstrom 2016-01-08 20:29:39 +01:00 committed by Dave Airlie
parent 38b1751913
commit fb89ac5102
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
View File

@ -247,7 +247,7 @@ static void __vmw_cmdbuf_header_free(struct vmw_cmdbuf_header *header)
{ {
struct vmw_cmdbuf_man *man = header->man; struct vmw_cmdbuf_man *man = header->man;
BUG_ON(!spin_is_locked(&man->lock)); lockdep_assert_held_once(&man->lock);
if (header->inline_space) { if (header->inline_space) {
vmw_cmdbuf_header_inline_free(header); vmw_cmdbuf_header_inline_free(header);