TPM: get_event_name stack corruption
get_event_name uses sprintf to fill a buffer declared on the stack. It fills the buffer 2 bytes at a time. What the code doesn't take into account is that sprintf(buf, "%02x", data) actually writes 3 bytes. 2 bytes for the data and then it nul terminates the string. Since we declare buf to be 40 characters long and then we write 40 bytes of data into buf sprintf is going to write 41 characters. The fix is to leave room in buf for the nul terminator. Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: James Morris <jmorris@namei.org>
This commit is contained in:
parent
279e677faa
commit
fbaa58696c
@ -212,7 +212,8 @@ static int get_event_name(char *dest, struct tcpa_event *event,
|
||||
unsigned char * event_entry)
|
||||
{
|
||||
const char *name = "";
|
||||
char data[40] = "";
|
||||
/* 41 so there is room for 40 data and 1 nul */
|
||||
char data[41] = "";
|
||||
int i, n_len = 0, d_len = 0;
|
||||
struct tcpa_pc_event *pc_event;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user