iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: dgap: tty.c: removes smatch warnings "redundant null check"

Browse Source 
This patch removes these smatch warnings:
redundant null check on dgap_TmpWriteBuf calling kfree()
redundant null check on brd->SerialDriver->ttys calling kfree()
redundant null check on brd->PrintDriver->ttys calling kfree()

The code checked to see if these variables are null
before freeing. This check isn't needed.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Lidza Louina 2013-09-23 18:47:15 -04:00 committed by Greg Kroah-Hartman
parent 913b6f8e0d
commit fcfeef6c51
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/staging/dgap/dgap_tty.c
View File

@ -497,10 +497,8 @@ int dgap_tty_init(struct board_t *brd)
*/ */
void dgap_tty_post_uninit(void) void dgap_tty_post_uninit(void)
{ {
if (dgap_TmpWriteBuf) { kfree(dgap_TmpWriteBuf);
kfree(dgap_TmpWriteBuf); dgap_TmpWriteBuf = NULL;
dgap_TmpWriteBuf = NULL;
}
} }
@ -522,10 +520,8 @@ void dgap_tty_uninit(struct board_t *brd)
tty_unregister_device(brd->SerialDriver, i); tty_unregister_device(brd->SerialDriver, i);
} }
tty_unregister_driver(brd->SerialDriver); tty_unregister_driver(brd->SerialDriver);
if (brd->SerialDriver->ttys) { kfree(brd->SerialDriver->ttys);
kfree(brd->SerialDriver->ttys); brd->SerialDriver->ttys = NULL;
brd->SerialDriver->ttys = NULL;
}
put_tty_driver(brd->SerialDriver); put_tty_driver(brd->SerialDriver);
brd->dgap_Major_Serial_Registered = FALSE; brd->dgap_Major_Serial_Registered = FALSE;
} }
@ -538,10 +534,8 @@ void dgap_tty_uninit(struct board_t *brd)
tty_unregister_device(brd->PrintDriver, i); tty_unregister_device(brd->PrintDriver, i);
} }
tty_unregister_driver(brd->PrintDriver); tty_unregister_driver(brd->PrintDriver);
if (brd->PrintDriver->ttys) { kfree(brd->PrintDriver->ttys);
kfree(brd->PrintDriver->ttys); brd->PrintDriver->ttys = NULL;
brd->PrintDriver->ttys = NULL;
}
put_tty_driver(brd->PrintDriver); put_tty_driver(brd->PrintDriver);
brd->dgap_Major_TransparentPrint_Registered = FALSE; brd->dgap_Major_TransparentPrint_Registered = FALSE;
} }