iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selftests/powerpc: Ensure 16-byte stack pointer alignment

Browse Source 
The PUSH/POP_BASIC_STACK helpers in basic_asm.h do not ensure that the
stack pointer is always 16-byte aligned, which is required per the ABI.

Fix the macros to do the alignment if the caller fails to.

Currently only one caller passes a non-aligned size, tm_signal_self(),
which hasn't been caught in testing, presumably because it's a leaf
function.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220627140239.2464900-1-mpe@ellerman.id.au
This commit is contained in:
Michael Ellerman 2022-06-28 00:02:27 +10:00
parent 2b461880c2
commit fd19a1f72a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/testing/selftests/powerpc/include/basic_asm.h
View File

@ -58,7 +58,7 @@
#define PUSH_BASIC_STACK(_extra) \
mflr r0; \
std r0, STACK_FRAME_LR_POS(%r1); \
stdu %r1, -(_extra + STACK_FRAME_MIN_SIZE)(%r1); \
stdu %r1, -(((_extra + 15) & ~15) + STACK_FRAME_MIN_SIZE)(%r1); \
mfcr r0; \
stw r0, STACK_FRAME_CR_POS(%r1); \
std %r2, STACK_FRAME_TOC_POS(%r1);
@ -67,7 +67,7 @@
ld %r2, STACK_FRAME_TOC_POS(%r1); \
lwz r0, STACK_FRAME_CR_POS(%r1); \
mtcr r0; \
addi %r1, %r1, (_extra + STACK_FRAME_MIN_SIZE); \
addi %r1, %r1, (((_extra + 15) & ~15) + STACK_FRAME_MIN_SIZE); \
ld r0, STACK_FRAME_LR_POS(%r1); \
mtlr r0;