iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ext4: unindent codeblock in ext4_xattr_block_set()

Browse Source 
Remove unnecessary else (and thus indentation level) from a code block
in ext4_xattr_block_set(). It will also make following code changes
easier. No functional changes.

CC: stable@vger.kernel.org
Fixes: 82939d7999df ("ext4: convert to mbcache2")
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220712105436.32204-4-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Jan Kara 2022-07-12 12:54:23 +02:00 committed by Theodore Ts'o
parent 6bc0d63dad
commit fd48e9acdf
1 changed files with 38 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

77
fs/ext4/xattr.c
View File

@ -1850,6 +1850,8 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
#define header(x) ((struct ext4_xattr_header *)(x)) #define header(x) ((struct ext4_xattr_header *)(x))
if (s->base) { if (s->base) {
int offset = (char *)s->here - bs->bh->b_data;
BUFFER_TRACE(bs->bh, "get_write_access"); BUFFER_TRACE(bs->bh, "get_write_access");
error = ext4_journal_get_write_access(handle, sb, bs->bh, error = ext4_journal_get_write_access(handle, sb, bs->bh,
EXT4_JTR_NONE); EXT4_JTR_NONE);
@ -1882,49 +1884,46 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
if (error) if (error)
goto cleanup; goto cleanup;
goto inserted; goto inserted;
} else { }
int offset = (char *)s->here - bs->bh->b_data; unlock_buffer(bs->bh);
ea_bdebug(bs->bh, "cloning");
s->base = kmemdup(BHDR(bs->bh), bs->bh->b_size, GFP_NOFS);
error = -ENOMEM;
if (s->base == NULL)
goto cleanup;
s->first = ENTRY(header(s->base)+1);
header(s->base)->h_refcount = cpu_to_le32(1);
s->here = ENTRY(s->base + offset);
s->end = s->base + bs->bh->b_size;
unlock_buffer(bs->bh); /*
ea_bdebug(bs->bh, "cloning"); * If existing entry points to an xattr inode, we need
s->base = kmemdup(BHDR(bs->bh), bs->bh->b_size, GFP_NOFS); * to prevent ext4_xattr_set_entry() from decrementing
error = -ENOMEM; * ref count on it because the reference belongs to the
if (s->base == NULL) * original block. In this case, make the entry look
* like it has an empty value.
*/
if (!s->not_found && s->here->e_value_inum) {
ea_ino = le32_to_cpu(s->here->e_value_inum);
error = ext4_xattr_inode_iget(inode, ea_ino,
le32_to_cpu(s->here->e_hash),
&tmp_inode);
if (error)
goto cleanup; goto cleanup;
s->first = ENTRY(header(s->base)+1);
header(s->base)->h_refcount = cpu_to_le32(1);
s->here = ENTRY(s->base + offset);
s->end = s->base + bs->bh->b_size;
/* if (!ext4_test_inode_state(tmp_inode,
* If existing entry points to an xattr inode, we need EXT4_STATE_LUSTRE_EA_INODE)) {
* to prevent ext4_xattr_set_entry() from decrementing /*
* ref count on it because the reference belongs to the * Defer quota free call for previous
* original block. In this case, make the entry look * inode until success is guaranteed.
* like it has an empty value. */
*/ old_ea_inode_quota = le32_to_cpu(
if (!s->not_found && s->here->e_value_inum) { s->here->e_value_size);
ea_ino = le32_to_cpu(s->here->e_value_inum);
error = ext4_xattr_inode_iget(inode, ea_ino,
le32_to_cpu(s->here->e_hash),
&tmp_inode);
if (error)
goto cleanup;
if (!ext4_test_inode_state(tmp_inode,
EXT4_STATE_LUSTRE_EA_INODE)) {
/*
* Defer quota free call for previous
* inode until success is guaranteed.
*/
old_ea_inode_quota = le32_to_cpu(
s->here->e_value_size);
}
iput(tmp_inode);
s->here->e_value_inum = 0;
s->here->e_value_size = 0;
} }
iput(tmp_inode);
s->here->e_value_inum = 0;
s->here->e_value_size = 0;
} }
} else { } else {
/* Allocate a buffer where we construct the new block. */ /* Allocate a buffer where we construct the new block. */