iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

firmware: vpd: Fix platform driver and device registration/unregistration

Browse Source 
commit 0631fb8b02 upstream.

The driver exit function needs to unregister both platform device and
driver. Also, during registration, register driver first and perform
error checks.

Fixes: 049a59db34 ("firmware: Google VPD sysfs driver")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Guenter Roeck
2017-11-15 13:00:45 -08:00
committed by Greg Kroah-Hartman
parent 03bb8e9a18
commit ff8307709c
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/firmware/google/vpd.c
View File

@ -326,21 +326,29 @@ static struct platform_driver vpd_driver = {
}, },
}; };
static struct platform_device *vpd_pdev;
static int __init vpd_platform_init(void) static int __init vpd_platform_init(void)
{ {
struct platform_device *pdev; int ret;
pdev = platform_device_register_simple("vpd", -1, NULL, 0); ret = platform_driver_register(&vpd_driver);
if (IS_ERR(pdev)) if (ret)
return PTR_ERR(pdev); return ret;
platform_driver_register(&vpd_driver); vpd_pdev = platform_device_register_simple("vpd", -1, NULL, 0);
if (IS_ERR(vpd_pdev)) {
platform_driver_unregister(&vpd_driver);
return PTR_ERR(vpd_pdev);
}
return 0; return 0;
} }
static void __exit vpd_platform_exit(void) static void __exit vpd_platform_exit(void)
{ {
platform_device_unregister(vpd_pdev);
platform_driver_unregister(&vpd_driver);
} }
module_init(vpd_platform_init); module_init(vpd_platform_init);