iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

netlink: specs: ethtool: define header-flags as an enum

Browse Source 
Recent changes added header flags to the spec.
Use an enum instead of defines for more seamless codegen.

[Jakub: drop the already applied parts and rewrite message]

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Link: https://lore.kernel.org/r/20240403212931.128541-6-rrameshbabu@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Jakub Kicinski 2024-04-05 22:22:38 -07:00
parent 3579032c08
commit ff8877b04e
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Documentation/netlink/specs/ethtool.yaml
View File

@ -18,7 +18,6 @@ definitions:
entries: [] entries: []
- -
name: header-flags name: header-flags
enum-name:
type: flags type: flags
entries: [ compact-bitsets, omit-reply, stats ] entries: [ compact-bitsets, omit-reply, stats ]

11
include/uapi/linux/ethtool_netlink.h
View File

@ -117,12 +117,11 @@ enum {
/* request header */ /* request header */
/* use compact bitsets in reply */ enum ethtool_header_flags {
#define ETHTOOL_FLAG_COMPACT_BITSETS (1 << 0) ETHTOOL_FLAG_COMPACT_BITSETS = 1 << 0, /* use compact bitsets in reply */
/* provide optional reply for SET or ACT requests */ ETHTOOL_FLAG_OMIT_REPLY = 1 << 1, /* provide optional reply for SET or ACT requests */
#define ETHTOOL_FLAG_OMIT_REPLY (1 << 1) ETHTOOL_FLAG_STATS = 1 << 2, /* request statistics, if supported by the driver */
/* request statistics, if supported by the driver */ };
#define ETHTOOL_FLAG_STATS (1 << 2)
#define ETHTOOL_FLAG_ALL (ETHTOOL_FLAG_COMPACT_BITSETS | \ #define ETHTOOL_FLAG_ALL (ETHTOOL_FLAG_COMPACT_BITSETS | \
ETHTOOL_FLAG_OMIT_REPLY | \ ETHTOOL_FLAG_OMIT_REPLY | \