iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bridge: mcast snooping, fix length check of snooped MLDv1/2

Browse Source 
"len = ntohs(ip6h->payload_len)" does not include the length of the ipv6
header itself, which the rest of this function assumes, though.

This leads to a length check less restrictive as it should be in the
following line for one thing. For another, it very likely leads to an
integer underrun when substracting the offset and therefore to a very
high new value of 'len' due to its unsignedness. This will ultimately
lead to the pskb_trim_rcsum() practically never being called, even in
the cases where it should.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Linus Lüssing 2011-03-26 20:27:24 +00:00 committed by David S. Miller
parent fd1d9188f2
commit ff9a57a62a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/bridge/br_multicast.c
View File

@ -1475,7 +1475,7 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br,
ip6h->payload_len == 0) ip6h->payload_len == 0)
return 0; return 0;
len = ntohs(ip6h->payload_len); len = ntohs(ip6h->payload_len) + sizeof(*ip6h);
if (skb->len < len) if (skb->len < len)
return -EINVAL; return -EINVAL;