iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy()

Browse Source 
If the cgroup destruction races with an exit() of a belonging
process(es), cg_kill_all() may fail. It's not a good reason to make
cg_destroy() fail and leave the cgroup in place, potentially causing
next test runs to fail.

Signed-off-by: Roman Gushchin <guro@fb.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: kernel-team@fb.com
Cc: linux-kselftest@vger.kernel.org
This commit is contained in:
Roman Gushchin
2019-04-19 10:03:05 -07:00
committed by Tejun Heo
parent 76f969e894
commit ff9fb7cb51
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/testing/selftests/cgroup/cgroup_util.c
View File

@ -227,9 +227,7 @@ int cg_destroy(const char *cgroup)
retry: retry:
ret = rmdir(cgroup); ret = rmdir(cgroup);
if (ret && errno == EBUSY) { if (ret && errno == EBUSY) {
ret = cg_killall(cgroup); cg_killall(cgroup);
if (ret)
return ret;
usleep(100); usleep(100);
goto retry; goto retry;
} }