iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ia64: add show_stack_loglvl()

Browse Source 
Currently, the log-level of show_stack() depends on a platform
realization.  It creates situations where the headers are printed with
lower log level or higher than the stacktrace (depending on a platform or
user).

Furthermore, it forces the logic decision from user to an architecture
side.  In result, some users as sysrq/kdb/etc are doing tricks with
temporary rising console_loglevel while printing their messages.  And in
result it not only may print unwanted messages from other CPUs, but also
omit printing at all in the unlucky case where the printk() was deferred.

Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier
approach than introducing more printk buffers.  Also, it will consolidate
printings with headers.

Introduce show_stack_loglvl(), that eventually will substitute
show_stack().

[1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u

Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Link: http://lkml.kernel.org/r/20200418201944.482088-17-dima@arista.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Dmitry Safonov 2020-06-08 21:30:44 -07:00 committed by Linus Torvalds
parent c261ad6ee8
commit ffdac29e40
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
arch/ia64/kernel/process.c
View File

@ -85,18 +85,25 @@ ia64_do_show_stack (struct unw_frame_info *info, void *arg)
}
void
show_stack (struct task_struct *task, unsigned long *sp)
show_stack_loglvl (struct task_struct *task, unsigned long *sp,
const char *loglvl)
{
if (!task)
unw_init_running(ia64_do_show_stack, (void *)KERN_DEFAULT);
unw_init_running(ia64_do_show_stack, (void *)loglvl);
else {
struct unw_frame_info info;
unw_init_from_blocked_task(&info, task);
ia64_do_show_stack(&info, (void *)KERN_DEFAULT);
ia64_do_show_stack(&info, (void *)loglvl);
}
}
void
show_stack (struct task_struct *task, unsigned long *sp)
{
show_stack_loglvl(task, sp, KERN_DEFAULT);
}
void
show_regs (struct pt_regs *regs)
{