iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,215,512 Commits 104 Branches 1,843 Tags
Commit Graph

53 Commits

Author SHA1 Message Date
Kent Overstreet
23bbd2bb8f bcachefs: Fix bch2_btree_node_iter_fix() 
bch2_btree_node_iter_prev_all() depends on an invariant that wasn't
being maintained for extent leaf nodes - specifically, the node iterator
may not have advanced past any keys that compare after the key the node
iterator points to.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:25 -04:00
Kent Overstreet
9df279407a bcachefs: Fix __bch2_btree_iter_peek_slot_extents() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:25 -04:00
Kent Overstreet
63f1a59847 bcachefs: Improved debug checks 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:25 -04:00
Kent Overstreet
1904a65a31 bcachefs: Ensure bch2_trans_get_iter() returns iters with correct locks 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:25 -04:00
Kent Overstreet
37dd783474 bcachefs: Fix an error path in bch2_btree_iter_traverse() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
3838be7841 bcachefs: Don't use a fixed size buffer for fs_usage_deltas 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
61011ea237 bcachefs: Rip out old hacky transaction restart tracing 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
20bceecb31 bcachefs: More work to avoid transaction restarts 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
7d82586660 bcachefs: Avoid spurious transaction restarts 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
0e6dd8fba0 bcachefs: Ensure bch2_btree_iter_next() always advances 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
58fbf80834 bcachefs: Delete duplicate code 
Also rename for consistency

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
ed8413fdab bcachefs: improved btree locking tracepoints 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
60755344c6 bcachefs: kill BTREE_ITER_NOUNLOCK 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
b03b81dfd2 bcachefs: Don't pass around may_drop_locks 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
b7607ce98f bcachefs: Kill remaining bch2_btree_iter_unlock() uses 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:21 -04:00
Kent Overstreet
932aa83745 bcachefs: bch2_trans_mark_update() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:21 -04:00
Kent Overstreet
c43a6ef9a0 bcachefs: btree_bkey_cached_common 
This is prep work for the btree key cache: btree iterators will point to
either struct btree, or a new struct bkey_cached.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:21 -04:00
Kent Overstreet
33eb63e575 bcachefs: Fix a bug with multiple iterators being traversed 
If upgrade fails on one iterator, but it was copied from another
iterator and will be freed before transaction restart, then the original
iterator will get traversed first, so we need to make required btree
nodes on the original iterator will be traversed too.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:21 -04:00
Kent Overstreet
ab5c63f5dd bcachefs: Don't hardcode BTREE_ID_EXTENTS 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:21 -04:00
Kent Overstreet
ba5c65576b bcachefs: Add actual tracepoints for transaction restarts 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:21 -04:00
Kent Overstreet
1dd7f9d98d bcachefs: Rewrite journal_seq_blacklist machinery 
Now, we store blacklisted journal sequence numbers in the superblock,
not the journal: this helps to greatly simplify the code, and more
importantly it's now implemented in a way that doesn't require all btree
nodes to be visited before starting the journal - instead, we
unconditionally blacklist the next 4 journal sequence numbers after an
unclean shutdown.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:20 -04:00
Kent Overstreet
ece254b258 bcachefs: don't lose errors from iterators that have been freed 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:20 -04:00
Kent Overstreet
4c1c1e3953 bcachefs: fix bch2_trans_unlock() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
a2b6b0729e bcachefs: add missing bch2_btree_iter_node_drop() call 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
f13f5a8c83 bcachefs: move some checks to expensive_debug_checks 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
4afe700060 bcachefs: Unlink not-touched iters on successful transaction commit 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
bf7b87a4a9 bcachefs: traverse all iterators on transaction restart 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
e1120a4c8d bcachefs: Add iter->idx 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
ecc892e40b bcachefs: Kill btree_iter->next 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
e542029eeb bcachefs: Change btree_iter_traverse_error() to not use iter->next 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
0f23836771 bcachefs: trans_for_each_iter() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:18 -04:00
Kent Overstreet
7c26ecae32 bcachefs: Better bch2_trans_copy_iter() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:18 -04:00
Kent Overstreet
9e5e5b9e71 bcachefs: Btree iterators now always have a btree_trans 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:18 -04:00
Kent Overstreet
424eb88130 bcachefs: Only get btree iters from btree transactions 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:18 -04:00
Kent Overstreet
5df4be3f62 bcachefs: Btree iter improvements 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:18 -04:00
Kent Overstreet
a8e00bd48a bcachefs: increase BTREE_ITER_MAX 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:17 -04:00
Kent Overstreet
446c562c2c bcachefs: Remove direct use of bch2_btree_iter_link() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:17 -04:00
Kent Overstreet
56e0e7c79f bcachefs: fix an incorrect bkey_debugcheck() call 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:13 -04:00
Kent Overstreet
26609b619f bcachefs: Make bkey types globally unique 
this lets us get rid of a lot of extra switch statements - in a lot of
places we dispatch on the btree node type, and then the key type, so
this is a nice cleanup across a lot of code.

Also improve the on disk format versioning stuff.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
ad7ae8d63f bcachefs: Btree locking fix, refactoring 
Hit an assertion, probably spurious, indicating an iterator was unlocked
when it shouldn't have been (spurious because it wasn't locked at all
when the caller called btree_insert_at()).

Add a flag, BTREE_ITER_NOUNLOCK, and tighten up the assertions

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
8812600c29 bcachefs: fix btree iterator bug when using depth > 0 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
319f9ac38e bcachefs: revamp to_text methods 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:11 -04:00
Kent Overstreet
cbdf24cef1 bcachefs: Fix a btree iter bug when iter pos == POS_MAX 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:09 -04:00
Kent Overstreet
a00fd8c535 bcachefs: Comparison function cleanups 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:09 -04:00
Kent Overstreet
216c9facfd bcachefs: Pass around bset_tree less 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:09 -04:00
Kent Overstreet
fc3268c13c bcachefs: kill extent_insert_hook 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:09 -04:00
Kent Overstreet
08af47dfc2 bcachefs: convert bchfs_write_index_update() to bch2_extent_update() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:09 -04:00
Kent Overstreet
581edb6341 bcachefs: mempoolify btree_trans 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:09 -04:00
Kent Overstreet
e4ccb25131 bcachefs: make struct btree_iter a bit smaller 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:09 -04:00
Kent Overstreet
271a3d3a4b bcachefs: lift ordering restriction on 0 size extents 
This lifts the restriction that 0 size extents must not overlap with
other extents, which means we can now sort extents and non extents the
same way, and will let us simplify a bunch of other stuff as well.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:09 -04:00