iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,215,589 Commits 104 Branches 1,843 Tags
Commit Graph

60 Commits

Author SHA1 Message Date
Justin Husted
f7c0fcdd39 bcachefs: Fix uninitialized data in bch2_gc_btree() 
Running the filesystem under valgrind exposed a path where the max_stale
variable in bch2_gc_btree() might not be initialized before use in a
rare case when there are no btree nodes in a transaction.

Signed-off-by: Justin Husted <sigstop@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:29 -04:00
Kent Overstreet
0741d37821 bcachefs: Don't allocate memory under mark_lock 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:28 -04:00
Kent Overstreet
89b0511826 bcachefs: Flush fsck errors when looping in btree gc 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:26 -04:00
Kent Overstreet
06ab329c15 bcachefs: Improve pointer marking checks and error messages 
Importantly, we don't want to use bch2_fs_inconsistent_on() for errors
that fsck can repair, becuase that will just put us in RO mode and
prevent fsck from actually fixing stuff. Probably want to get rid of it
in the future.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:26 -04:00
Kent Overstreet
6671a7089f bcachefs: Refactor bch2_alloc_write() 
Major simplification - gets rid of the need for marking buckets as
dirty, instead we write buckets if the in memory mark is different from
what's in the btree.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:26 -04:00
Kent Overstreet
2cbe5cfe27 bcachefs: Rework calling convention for marking overwrites 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:25 -04:00
Kent Overstreet
6e738539cd bcachefs: Improve key marking interface 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
20bceecb31 bcachefs: More work to avoid transaction restarts 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:22 -04:00
Kent Overstreet
c43a6ef9a0 bcachefs: btree_bkey_cached_common 
This is prep work for the btree key cache: btree iterators will point to
either struct btree, or a new struct bkey_cached.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:21 -04:00
Kent Overstreet
5e82a9a1f4 bcachefs: Write out fs usage consistently 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:21 -04:00
Kent Overstreet
94f651e2c7 bcachefs: Return errors from for_each_btree_key() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:20 -04:00
Kent Overstreet
c6dd04f8f5 bcachefs: Mark overwrites from journal replay in initial gc 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:20 -04:00
Kent Overstreet
d07343561e bcachefs: Deduplicate keys in the journal before replay 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:20 -04:00
Kent Overstreet
4881fdb756 bcachefs: initial gc no longer needs to touch every node 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:20 -04:00
Kent Overstreet
a1d58243f9 bcachefs: add ability to run gc on metadata only 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:20 -04:00
Kent Overstreet
cccf4e6df3 bcachefs: Convert gc errors to fsck errors 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:20 -04:00
Kent Overstreet
36e916e13b bcachefs: Caller now responsible for calling mark_key for gc 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
3a0e06db71 bcachefs: Assorted preemption fixes 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
ccaa61c9f6 bcachefs: fix initial gc 
Buckets weren't being marked as dirty

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
05b3d5ac1f bcachefs: simplify gc locking a bit 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:19 -04:00
Kent Overstreet
424eb88130 bcachefs: Only get btree iters from btree transactions 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:18 -04:00
Kent Overstreet
8b2b9d11b9 bcachefs: Fix error handling in gc 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:18 -04:00
Kent Overstreet
6122ab639c bcachefs: More debug params for testing of recovery paths 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:18 -04:00
Kent Overstreet
28062d320b bcachefs: Fix gc handling of bucket gens 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:16 -04:00
Kent Overstreet
ecf37a4a80 bcachefs: fs_usage_u64s() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:16 -04:00
Kent Overstreet
768ac63924 bcachefs: Add a mechanism for blocking the journal 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:16 -04:00
Kent Overstreet
8777210b92 bcachefs: refactor key marking code a bit 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:16 -04:00
Kent Overstreet
39fbc5a49f bcachefs: gc lock no longer needed for disk reservations 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:16 -04:00
Kent Overstreet
76f4c7b0c3 bcachefs: Fix oldest_gen handling 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:15 -04:00
Kent Overstreet
1df42b5715 bcachefs: don't do initial gc if have alloc info feature 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:15 -04:00
Kent Overstreet
42b72e0ba2 bcachefs: journal_replay_early() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:15 -04:00
Kent Overstreet
61c8d7c8eb bcachefs: Persist stripe blocks_used 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:15 -04:00
Kent Overstreet
7ef2a73a58 bcachefs: Fix check for if extent update is allocating 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:14 -04:00
Kent Overstreet
23f80d2b3b bcachefs: Factor out acc_u64s() 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:14 -04:00
Kent Overstreet
06b7345cc2 bcachefs: Include summarized counts in fs_usage 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:13 -04:00
Kent Overstreet
9166b41db1 bcachefs: s/usage_lock/mark_lock 
better describes what it's for, and we're going to call a new lock
usage_lock

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:13 -04:00
Kent Overstreet
8eb7f3ee46 bcachefs: move dirty into bucket_mark 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
90541a741d bcachefs: Add new alloc fields 
prep work for persistent alloc info

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
f0cfb963ec bcachefs: Track nr_inodes with the key marking machinery 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
26609b619f bcachefs: Make bkey types globally unique 
this lets us get rid of a lot of extra switch statements - in a lot of
places we dispatch on the btree node type, and then the key type, so
this is a nice cleanup across a lot of code.

Also improve the on disk format versioning stuff.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
d034c09b26 bcachefs: return errors correctly from gc 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
eeb83e25bb bcachefs: Hold usage_lock over mark_key and fs_usage_apply 
Fixes an inconsistency at the end of gc

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
dfe9bfb32e bcachefs: Stripes now properly subject to gc 
gc now verifies the contents of the stripes radix tree, important for
persistent alloc info

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
ad7ae8d63f bcachefs: Btree locking fix, refactoring 
Hit an assertion, probably spurious, indicating an iterator was unlocked
when it shouldn't have been (spurious because it wasn't locked at all
when the caller called btree_insert_at()).

Add a flag, BTREE_ITER_NOUNLOCK, and tighten up the assertions

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
9ca53b55f7 bcachefs: gc now operates on second set of bucket marks 
This means we can now use gc to verify the allocation information -
important for testing persistant alloc info

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:12 -04:00
Kent Overstreet
cd575ddf57 bcachefs: Erasure coding 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:11 -04:00
Kent Overstreet
91f8b5677b bcachefs: More btree gc refactorings 
more prep work for erasure coding

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:11 -04:00
Kent Overstreet
1d25849c2c bcachefs: Centralize marking of replicas in btree update path 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:11 -04:00
Kent Overstreet
47799326bc bcachefs: more key marking refactoring 
prep work for erasure coding

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:10 -04:00
Kent Overstreet
103e212785 bcachefs: replicas: prep work for stripes 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
 2023-10-22 17:08:10 -04:00