907ed1328d
usermodehelper: split remaining calls to call_usermodehelper_fns()
...
These are the only users of call_usermodehelper_fns(). This function
suffers from not being able to determine if the cleanup is called. Even
if in this places the cleanup pointer is NULL, convert them to use the
separate call_usermodehelper_setup() + call_usermodehelper_exec()
functions so we can remove the _fns variant.
Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi >
Cc: Oleg Nesterov <oleg@redhat.com >
Cc: David Howells <dhowells@redhat.com >
Cc: James Morris <james.l.morris@oracle.com >
Cc: Al Viro <viro@zeniv.linux.org.uk >
Cc: Tejun Heo <tj@kernel.org >
Cc: "Rafael J. Wysocki" <rjw@sisk.pl >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-30 17:04:06 -07:00
fb96c475f6
coredump: remove trailling whitespace
...
Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi >
Cc: Oleg Nesterov <oleg@redhat.com >
Cc: David Howells <dhowells@redhat.com >
Cc: James Morris <james.l.morris@oracle.com >
Cc: Al Viro <viro@zeniv.linux.org.uk >
Cc: Tejun Heo <tj@kernel.org >
Cc: "Rafael J. Wysocki" <rjw@sisk.pl >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-04-30 17:04:06 -07:00
de32ec4cfe
pipe: set file->private_data to ->i_pipe
...
simplify get_pipe_info(), while we are at it
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2013-04-09 14:13:00 -04:00
03d95eb2f2
lift sb_start_write() out of ->write()
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2013-04-09 14:12:56 -04:00
e579d2c259
coredump: remove redundant defines for dumpable states
...
The existing SUID_DUMP_* defines duplicate the newer SUID_DUMPABLE_*
defines introduced in 54b501992dkeescook@chromium.org >
Reported-by: Chen Gang <gang.chen@asianux.com >
Cc: Alexander Viro <viro@zeniv.linux.org.uk >
Cc: Alan Cox <alan@linux.intel.com >
Cc: "Eric W. Biederman" <ebiederm@xmission.com >
Cc: Doug Ledford <dledford@redhat.com >
Cc: Serge Hallyn <serge.hallyn@canonical.com >
Cc: James Morris <james.l.morris@oracle.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2013-02-27 19:10:11 -08:00
496ad9aa8e
new helper: file_inode(file)
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2013-02-22 23:31:31 -05:00
541880d9a2
do_coredump(): get rid of pt_regs argument
...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2012-11-29 00:01:25 -05:00
45525b26a4
fix a leak in replace_fd() users
...
replace_fd() began with "eats a reference, tries to insert into
descriptor table" semantics; at some point I'd switched it to
much saner current behaviour ("try to insert into descriptor
table, grabbing a new reference if inserted; caller should do
fput() in any case"), but forgot to update the callers.
Mea culpa...
[Spotted by Pavel Roskin, who has really weird system with pipe-fed
coredumps as part of what he considers a normal boot ;-)]
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2012-10-16 13:36:50 -04:00
5ab1c309b3
coredump: pass siginfo_t* to do_coredump() and below, not merely signr
...
This is a preparatory patch for the introduction of NT_SIGINFO elf note.
With this patch we pass "siginfo_t *siginfo" instead of "int signr" to
do_coredump() and put it into coredump_params. It will be used by the
next patch. Most changes are simple s/signr/siginfo->si_signo/.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com >
Reviewed-by: Oleg Nesterov <oleg@redhat.com >
Cc: Amerigo Wang <amwang@redhat.com >
Cc: "Jonathan M. Foote" <jmfoote@cert.org >
Cc: Roland McGrath <roland@hack.frob.com >
Cc: Pedro Alves <palves@redhat.com >
Cc: Fengguang Wu <fengguang.wu@intel.com >
Cc: Stephen Rothwell <sfr@canb.auug.org.au >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-10-06 03:05:16 +09:00
12a2b4b224
coredump: add support for %d=__get_dumpable() in core name
...
Some coredump handlers want to create a core file in a way compatible with
standard behavior. Standard behavior with fs.suid_dumpable = 2 is to
create core file with uid=gid=0. However, there was no way for coredump
handler to know that the process being dumped was suid'ed.
This patch adds the new %d specifier for format_corename() which simply
reports __get_dumpable(mm->flags), this is compatible with
/proc/sys/fs/suid_dumpable we already have.
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=787135
Developed during a discussion with Denys Vlasenko.
Signed-off-by: Oleg Nesterov <oleg@redhat.com >
Cc: Denys Vlasenko <vda.linux@googlemail.com >
Cc: Alex Kelly <alex.page.kelly@gmail.com >
Cc: Andi Kleen <andi@firstfloor.org >
Cc: Cong Wang <amwang@redhat.com >
Cc: Jiri Moskovcak <jmoskovc@redhat.com >
Acked-by: Neil Horman <nhorman@tuxdriver.com >
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-10-06 03:05:15 +09:00
179899fd5d
coredump: update coredump-related headers
...
Create a new header file, fs/coredump.h, which contains functions only
used by the new coredump.c. It also moves do_coredump to the
include/linux/coredump.h header file, for consistency.
Signed-off-by: Alex Kelly <alex.page.kelly@gmail.com >
Reviewed-by: Josh Triplett <josh@joshtriplett.org >
Acked-by: Serge Hallyn <serge.hallyn@canonical.com >
Acked-by: Kees Cook <keescook@chromium.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2012-10-06 03:05:15 +09:00
10c28d937e
coredump: move core dump functionality into its own file
...
This prepares for making core dump functionality optional.
The variable "suid_dumpable" and associated functions are left in fs/exec.c
because they're used elsewhere, such as in ptrace.
Signed-off-by: Alex Kelly <alex.page.kelly@gmail.com >
Reviewed-by: Josh Triplett <josh@joshtriplett.org >
Acked-by: Serge Hallyn <serge.hallyn@canonical.com >
Acked-by: Kees Cook <keescook@chromium.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2012-10-02 21:35:55 -04:00
