152 Commits

Author SHA1 Message Date
Jason Cooper
d809dcb9df staging: brcm80211: remove kernel_thread() for _dhd_sysioc_thread.
Replaced kernel_thread() with kthread_run(), kthread_stop(), and
kthread_should_stop().  Also removed all references to sysioc_pid and
sysioc_exit.  DAEMONIZE removed because not used in dhd_linux.c.

sysioc_tsk is NULL when not running.

Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-10 05:39:49 -07:00
Jason Cooper
ecd7559d8d staging: brcm80211: remove kernel_thread() for dhd_dpc_thread.
use kthread_run(), kthread_stop(), and kthread_should_stop().  Removes
dpc_pid, dpc_exited, and the call to DAEMONIZE.

dpc_tsk is NULL when not running.

Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-10 05:39:48 -07:00
Jason Cooper
860708d9c8 staging: brcm80211: remove kernel_thread() for dhd_watchdog_thread.
Replaced kernel_thread() with kthread_run().  Used kthread_should_stop()
in place of watchdog_exited completion.  Replaced watchdog_pid with
struct task_struct.

watchdog_tsk is NULL when the task is not running.

Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-10 05:39:47 -07:00
nohee ko
839fad996b staging: brcm80211: remove unnecessary cflag, LINUX
remove unnecessary cflag, LINUX

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-09 13:49:43 -07:00
nohee ko
1e8dd5b9b3 staging: brcm80211: remove unnecessary cflag, CONFIG_CFG80211
remove unnecessary cflag, CONFIG_CFG80211

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-09 13:49:42 -07:00
nohee ko
5e33a02ff7 staging: brcm80211: remove unnecessary cflag, BCMWPA2
remove unnecessary cflag, BCMWPA2.
BCMDRIVER is already not used.

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-09 13:49:42 -07:00
nohee ko
ea3b8a2810 staging: brcm80211: remove duplicated file, bcmutils.c
Remove duplicated file, bcmutils.c under brcm80211/brcmfmac.
brcm80211/util/bcmutils.c will be shared between softmac
& fullmac. Makefile, and some other files are also modified
accordingly

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-09 13:49:41 -07:00
Dan Carpenter
cbf6baac77 Staging: brcm80211: make interface name buffer smaller
In the original code the interface name was IFNAMSIZ + 1, but that
caused problems in dhd_ifname2idx() which does:
	strncmp(dhd->iflist[i]->name, name, IFNAMSIZ)

The wl_event_msg_t struct can only store 16 character names as well.

And thirdly there is a potential buffer overflow in dhd_op_if() because
if->net->name is IFNAMSIZ and we do:
	strcpy(ifp->net->name, ifp->name);

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-09 13:49:40 -07:00
Brett Rudley
edae01b94a staging: brcm80211: Purge unused wlc_id_name
Purge unused wlc_id_name_entry

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 19:53:11 -07:00
Brett Rudley
a9a6073c51 staging: brcm80211: Purge unused packet engine
We're not using the packet engine anymore - goodbye.

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 19:53:10 -07:00
nohee ko
fb693a712c staging: brcm80211: bug fix- dual band problem
Bug fix for dual band problem. In particular it had an issue
to connect to 5G band AP.

Signed-off-by: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 19:53:10 -07:00
Brett Rudley
40e5c96b22 staging: brcm80211: Coalesce osl_dma_alloc_consistent between fullmac and softmac
Combine dma_alloc routine for full and softmac

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 14:32:52 -07:00
Brett Rudley
17b313857d staging: brcm80211: Purge unused memlist debugging
Purge unused memlist debugging

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 14:29:43 -07:00
Greg Kroah-Hartman
0d2f0724a4 Staging: brcm80211: remove BCMATTACHFN macro
It's not doing anything and is a bit silly.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 14:28:21 -07:00
Greg Kroah-Hartman
17c4da1ecf Staging: brcm80211: remove BCMATTACHDATA macro
It's not even used for anything, not to mention, it is pretty silly.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 14:11:20 -07:00
Greg Kroah-Hartman
b61640d1ac Staging: brcm80211: brcmfmac: fix some comparison warnings
Use min_t() instead of min() in some places to make the
comparison explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 12:37:39 -07:00
Greg Kroah-Hartman
a300ce95e4 Staging: brcm80211: sys: fix some comparison warnings
Use min_t() instead of min() in some places to make the
comparison explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 12:28:02 -07:00
Greg Kroah-Hartman
697d600d8f Staging: brcm80211: sys: wlc_ampdu: fix some comparison warnings
Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 12:25:23 -07:00
Greg Kroah-Hartman
e9e6727fcc Staging: brcm80211: phy: wlc_phy_n: fix some comparison warnings
Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.d
2010-10-08 12:16:08 -07:00
Greg Kroah-Hartman
c09cc58692 Staging: brcm80211: hnddma.c: fix compiler warning
Change the field types of dma_info_t to make comparing values easier
(and correct.)  No need to keep rxbufsize as a u16, it can be an
unsigned int to make things easier.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 12:07:33 -07:00
Greg Kroah-Hartman
96e76e6941 Staging: brcm80211: remove VALID_MASK macro
No one is using it.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 12:01:30 -07:00
Greg Kroah-Hartman
e18d5313c6 Staging: brcm80211: remove ROUNDUP macro
And use the kernel provided 'roundup' instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:59:06 -07:00
Greg Kroah-Hartman
36c63ff6af Staging: brcm80211: remove ISALIGNED macro
And use the kernel provided IS_ALIGNED one instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:55:40 -07:00
Greg Kroah-Hartman
d2733c97fa Staging: brcm80211: remove unused ALIGN_ADDR() macro
It's not used (and there's a kernel provided one if it's ever needed in
the future), so remove it.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:52:16 -07:00
Greg Kroah-Hartman
8d3d6a6945 Staging: brcm80211: remove ARRAYSIZE macro
Use the real 'ARRAY_SIZE' definition instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:47:11 -07:00
Greg Kroah-Hartman
ce0f1b8cd1 Staging: brcm80211: remove OFFSETOF macro
Use the real 'offsetof' definition instead.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:44:45 -07:00
Greg Kroah-Hartman
3ea2f4d640 Staging: brcm80211: remove broken MAX() implementation
Use the kernel-provided version, this one is broken.

Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way.  They need to be fixed up.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:39:43 -07:00
Greg Kroah-Hartman
7068c2f139 Staging: brcm80211: remove broken MIN() implementation
Use the kernel-provided version, this one is broken.

Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way.  They need to be fixed up.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:34:59 -07:00
Greg Kroah-Hartman
c03b63c198 Staging: brcm80211: util: remove unneeded usage of uintptr
Double casting is pretty pointless, don't do that.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:20:01 -07:00
Greg Kroah-Hartman
f1d0fe0abc Staging: brcm80211: remove unused typedefs in typedefs.h
uint is already defined somewhere else, so just remove this version
of it.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:13:11 -07:00
Greg Kroah-Hartman
3e26416e2f Staging: brcm80211: s/int32/s32/
Use the kernel types, don't invent your own.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:11:13 -07:00
Greg Kroah-Hartman
66cbd3ab35 Staging: brcm80211: s/uint32/u32/
Use the kernel types, don't invent your own.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 11:05:47 -07:00
Brett Rudley
588abaa64b staging: brcm80211: Use proper BRCM_FULLMAC #ifdefs
Make it obvious that DHD_USE_STATIC_BUF is only used as part of FULLMAC build

Signed-off-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 21:14:23 -07:00
Henry Ptasinski
1e3950b848 staging: brcm80211: Remove dead code from siutils.c
Removed lots of unused functions from siutils.c

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 20:03:27 -07:00
Henry Ptasinski
51c5651da4 staging: brcm80211: Remove dead code from bcmwifi.c
Removed unused functions wf_chspec_ntoa() and wf_chspec_aton().

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 20:03:27 -07:00
Henry Ptasinski
4ca70f7fcb staging: brcm80211: Remove dead code from linux_osl.c.
Removed several completely unused functions:
	osl_malloc_failed
	osl_pcmcia_attr
	osl_pcmcia_read_attr
	osl_pcmcia_write_attr
	osl_pktdup
and related macros

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 20:03:26 -07:00
Henry Ptasinski
45fa9a90a6 staging: brcm80211: Remove unnecessary hndtcam.h
The header file is unnecessary.  Delete it and don't include it.

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 20:03:26 -07:00
Henry Ptasinski
64cb45adda staging: brcm80211: Remove unnecessary bitfuncs.h
This header file is no longer included anywhere.

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 20:03:26 -07:00
Henry Ptasinski
b2324267a6 staging: brcm80211: Don't include bitfuncs.h
Remove include of bitfuncs.h, as it's completely uncessary for these files.

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 20:03:25 -07:00
Henry Ptasinski
d953a05d04 staging: brcm80211: Use linux/bitops.h instead of bitfuncs.h
Use ffs() from linux/bitops.h, instead of the locally defined find_msbit().

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 20:03:25 -07:00
Henry Ptasinski
86566325d3 staging: brcm80211: Remove dead code from aiutils.c
Removed unused function ai_view().

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 20:03:24 -07:00
Greg Kroah-Hartman
e59fe083f6 Staging: brcm80211: s/int16/s16/
Use the kernel types, don't invent your own.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 17:08:21 -07:00
Greg Kroah-Hartman
7d4df48eba Staging: brcm80211: s/uint16/u16/
Use the kernel types, don't invent your own.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 17:04:47 -07:00
Greg Kroah-Hartman
4128dd9afb Staging: brcm80211: remove forgotten undef
I forgot to remove the float undefs in typedef.h from previous patches,
this fixes this issue.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 16:41:32 -07:00
Greg Kroah-Hartman
11465f6a7d Staging: brcm80211: wl_cfg80211.c: fix compiler warnings
size_t should be '%zd' in a printf, not '%d'

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 16:38:43 -07:00
Greg Kroah-Hartman
1a3bf7471e Staging: brcm80211: remove some more macros from linuxver.h
These aren't needed anymore, and now we are down to just one broken one,
and a whole bunch of #include files here.  This can be further factored
by moving the proper #includes into the different .c files, and not
leaving them in this one large one.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 16:34:51 -07:00
Greg Kroah-Hartman
f149e6f1da Staging: brcm80211: remove unused irq typedef
If it's not needed, why define it?

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 16:30:25 -07:00
Greg Kroah-Hartman
878a667394 Staging: brcm80211: remove unneeded pm macro
Use the real type, not a macro.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 16:28:15 -07:00
Greg Kroah-Hartman
624573d0d4 Staging: brcm80211: remove some unused macros
These are all defined by the core kernel, use those versions
instead of just creating noops.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 16:25:58 -07:00
Greg Kroah-Hartman
8ba9cfdbfc Staging: brcm80211: remove unneeded pci macros
These wrapper macros aren't needed, remove them.

Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-07 16:23:24 -07:00