Patch series "Memory allocation profiling", v6. Overview: Low overhead [1] per-callsite memory allocation profiling. Not just for debug kernels, overhead low enough to be deployed in production. Example output: root@moria-kvm:~# sort -rn /proc/allocinfo 127664128 31168 mm/page_ext.c:270 func:alloc_page_ext 56373248 4737 mm/slub.c:2259 func:alloc_slab_page 14880768 3633 mm/readahead.c:247 func:page_cache_ra_unbounded 14417920 3520 mm/mm_init.c:2530 func:alloc_large_system_hash 13377536 234 block/blk-mq.c:3421 func:blk_mq_alloc_rqs 11718656 2861 mm/filemap.c:1919 func:__filemap_get_folio 9192960 2800 kernel/fork.c:307 func:alloc_thread_stack_node 4206592 4 net/netfilter/nf_conntrack_core.c:2567 func:nf_ct_alloc_hashtable 4136960 1010 drivers/staging/ctagmod/ctagmod.c:20 [ctagmod] func:ctagmod_start 3940352 962 mm/memory.c:4214 func:alloc_anon_folio 2894464 22613 fs/kernfs/dir.c:615 func:__kernfs_new_node ... Usage: kconfig options: - CONFIG_MEM_ALLOC_PROFILING - CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT - CONFIG_MEM_ALLOC_PROFILING_DEBUG adds warnings for allocations that weren't accounted because of a missing annotation sysctl: /proc/sys/vm/mem_profiling Runtime info: /proc/allocinfo Notes: [1]: Overhead To measure the overhead we are comparing the following configurations: (1) Baseline with CONFIG_MEMCG_KMEM=n (2) Disabled by default (CONFIG_MEM_ALLOC_PROFILING=y && CONFIG_MEM_ALLOC_PROFILING_BY_DEFAULT=n) (3) Enabled by default (CONFIG_MEM_ALLOC_PROFILING=y && CONFIG_MEM_ALLOC_PROFILING_BY_DEFAULT=y) (4) Enabled at runtime (CONFIG_MEM_ALLOC_PROFILING=y && CONFIG_MEM_ALLOC_PROFILING_BY_DEFAULT=n && /proc/sys/vm/mem_profiling=1) (5) Baseline with CONFIG_MEMCG_KMEM=y && allocating with __GFP_ACCOUNT (6) Disabled by default (CONFIG_MEM_ALLOC_PROFILING=y && CONFIG_MEM_ALLOC_PROFILING_BY_DEFAULT=n) && CONFIG_MEMCG_KMEM=y (7) Enabled by default (CONFIG_MEM_ALLOC_PROFILING=y && CONFIG_MEM_ALLOC_PROFILING_BY_DEFAULT=y) && CONFIG_MEMCG_KMEM=y Performance overhead: To evaluate performance we implemented an in-kernel test executing multiple get_free_page/free_page and kmalloc/kfree calls with allocation sizes growing from 8 to 240 bytes with CPU frequency set to max and CPU affinity set to a specific CPU to minimize the noise. Below are results from running the test on Ubuntu 22.04.2 LTS with 6.8.0-rc1 kernel on 56 core Intel Xeon: kmalloc pgalloc (1 baseline) 6.764s 16.902s (2 default disabled) 6.793s (+0.43%) 17.007s (+0.62%) (3 default enabled) 7.197s (+6.40%) 23.666s (+40.02%) (4 runtime enabled) 7.405s (+9.48%) 23.901s (+41.41%) (5 memcg) 13.388s (+97.94%) 48.460s (+186.71%) (6 def disabled+memcg) 13.332s (+97.10%) 48.105s (+184.61%) (7 def enabled+memcg) 13.446s (+98.78%) 54.963s (+225.18%) Memory overhead: Kernel size: text data bss dec diff (1) 26515311 18890222 17018880 62424413 (2) 26524728 19423818 16740352 62688898 264485 (3) 26524724 19423818 16740352 62688894 264481 (4) 26524728 19423818 16740352 62688898 264485 (5) 26541782 18964374 16957440 62463596 39183 Memory consumption on a 56 core Intel CPU with 125GB of memory: Code tags: 192 kB PageExts: 262144 kB (256MB) SlabExts: 9876 kB (9.6MB) PcpuExts: 512 kB (0.5MB) Total overhead is 0.2% of total memory. Benchmarks: Hackbench tests run 100 times: hackbench -s 512 -l 200 -g 15 -f 25 -P baseline disabled profiling enabled profiling avg 0.3543 0.3559 (+0.0016) 0.3566 (+0.0023) stdev 0.0137 0.0188 0.0077 hackbench -l 10000 baseline disabled profiling enabled profiling avg 6.4218 6.4306 (+0.0088) 6.5077 (+0.0859) stdev 0.0933 0.0286 0.0489 stress-ng tests: stress-ng --class memory --seq 4 -t 60 stress-ng --class cpu --seq 4 -t 60 Results posted at: https://evilpiepirate.org/~kent/memalloc_prof_v4_stress-ng/ [2] https://lore.kernel.org/all/20240306182440.2003814-1-surenb@google.com/ This patch (of 37): The next patch drops vmalloc.h from a system header in order to fix a circular dependency; this adds it to all the files that were pulling it in implicitly. [kent.overstreet@linux.dev: fix arch/alpha/lib/memcpy.c] Link: https://lkml.kernel.org/r/20240327002152.3339937-1-kent.overstreet@linux.dev [surenb@google.com: fix arch/x86/mm/numa_32.c] Link: https://lkml.kernel.org/r/20240402180933.1663992-1-surenb@google.com [kent.overstreet@linux.dev: a few places were depending on sizes.h] Link: https://lkml.kernel.org/r/20240404034744.1664840-1-kent.overstreet@linux.dev [arnd@arndb.de: fix mm/kasan/hw_tags.c] Link: https://lkml.kernel.org/r/20240404124435.3121534-1-arnd@kernel.org [surenb@google.com: fix arc build] Link: https://lkml.kernel.org/r/20240405225115.431056-1-surenb@google.com Link: https://lkml.kernel.org/r/20240321163705.3067592-1-surenb@google.com Link: https://lkml.kernel.org/r/20240321163705.3067592-2-surenb@google.com Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> Signed-off-by: Suren Baghdasaryan <surenb@google.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com> Tested-by: Kees Cook <keescook@chromium.org> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: Alex Gaynor <alex.gaynor@gmail.com> Cc: Alice Ryhl <aliceryhl@google.com> Cc: Andreas Hindborg <a.hindborg@samsung.com> Cc: Benno Lossin <benno.lossin@proton.me> Cc: "Björn Roy Baron" <bjorn3_gh@protonmail.com> Cc: Boqun Feng <boqun.feng@gmail.com> Cc: Christoph Lameter <cl@linux.com> Cc: Dennis Zhou <dennis@kernel.org> Cc: Gary Guo <gary@garyguo.net> Cc: Miguel Ojeda <ojeda@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Tejun Heo <tj@kernel.org> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Wedson Almeida Filho <wedsonaf@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
288 lines
6.9 KiB
C
288 lines
6.9 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/* Copyright (C) 2015-2018 Broadcom */
|
|
|
|
/**
|
|
* DOC: V3D GEM BO management support
|
|
*
|
|
* Compared to VC4 (V3D 2.x), V3D 3.3 introduces an MMU between the
|
|
* GPU and the bus, allowing us to use shmem objects for our storage
|
|
* instead of CMA.
|
|
*
|
|
* Physically contiguous objects may still be imported to V3D, but the
|
|
* driver doesn't allocate physically contiguous objects on its own.
|
|
* Display engines requiring physically contiguous allocations should
|
|
* look into Mesa's "renderonly" support (as used by the Mesa pl111
|
|
* driver) for an example of how to integrate with V3D.
|
|
*
|
|
* Long term, we should support evicting pages from the MMU when under
|
|
* memory pressure (thus the v3d_bo_get_pages() refcounting), but
|
|
* that's not a high priority since our systems tend to not have swap.
|
|
*/
|
|
|
|
#include <linux/dma-buf.h>
|
|
#include <linux/pfn_t.h>
|
|
#include <linux/vmalloc.h>
|
|
|
|
#include "v3d_drv.h"
|
|
#include "uapi/drm/v3d_drm.h"
|
|
|
|
/* Called DRM core on the last userspace/kernel unreference of the
|
|
* BO.
|
|
*/
|
|
void v3d_free_object(struct drm_gem_object *obj)
|
|
{
|
|
struct v3d_dev *v3d = to_v3d_dev(obj->dev);
|
|
struct v3d_bo *bo = to_v3d_bo(obj);
|
|
|
|
if (bo->vaddr)
|
|
v3d_put_bo_vaddr(bo);
|
|
|
|
v3d_mmu_remove_ptes(bo);
|
|
|
|
mutex_lock(&v3d->bo_lock);
|
|
v3d->bo_stats.num_allocated--;
|
|
v3d->bo_stats.pages_allocated -= obj->size >> V3D_MMU_PAGE_SHIFT;
|
|
mutex_unlock(&v3d->bo_lock);
|
|
|
|
spin_lock(&v3d->mm_lock);
|
|
drm_mm_remove_node(&bo->node);
|
|
spin_unlock(&v3d->mm_lock);
|
|
|
|
/* GPU execution may have dirtied any pages in the BO. */
|
|
bo->base.pages_mark_dirty_on_put = true;
|
|
|
|
drm_gem_shmem_free(&bo->base);
|
|
}
|
|
|
|
static const struct drm_gem_object_funcs v3d_gem_funcs = {
|
|
.free = v3d_free_object,
|
|
.print_info = drm_gem_shmem_object_print_info,
|
|
.pin = drm_gem_shmem_object_pin,
|
|
.unpin = drm_gem_shmem_object_unpin,
|
|
.get_sg_table = drm_gem_shmem_object_get_sg_table,
|
|
.vmap = drm_gem_shmem_object_vmap,
|
|
.vunmap = drm_gem_shmem_object_vunmap,
|
|
.mmap = drm_gem_shmem_object_mmap,
|
|
.vm_ops = &drm_gem_shmem_vm_ops,
|
|
};
|
|
|
|
/* gem_create_object function for allocating a BO struct and doing
|
|
* early setup.
|
|
*/
|
|
struct drm_gem_object *v3d_create_object(struct drm_device *dev, size_t size)
|
|
{
|
|
struct v3d_bo *bo;
|
|
struct drm_gem_object *obj;
|
|
|
|
if (size == 0)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
bo = kzalloc(sizeof(*bo), GFP_KERNEL);
|
|
if (!bo)
|
|
return ERR_PTR(-ENOMEM);
|
|
obj = &bo->base.base;
|
|
|
|
obj->funcs = &v3d_gem_funcs;
|
|
bo->base.map_wc = true;
|
|
INIT_LIST_HEAD(&bo->unref_head);
|
|
|
|
return &bo->base.base;
|
|
}
|
|
|
|
static int
|
|
v3d_bo_create_finish(struct drm_gem_object *obj)
|
|
{
|
|
struct v3d_dev *v3d = to_v3d_dev(obj->dev);
|
|
struct v3d_bo *bo = to_v3d_bo(obj);
|
|
struct sg_table *sgt;
|
|
int ret;
|
|
|
|
/* So far we pin the BO in the MMU for its lifetime, so use
|
|
* shmem's helper for getting a lifetime sgt.
|
|
*/
|
|
sgt = drm_gem_shmem_get_pages_sgt(&bo->base);
|
|
if (IS_ERR(sgt))
|
|
return PTR_ERR(sgt);
|
|
|
|
spin_lock(&v3d->mm_lock);
|
|
/* Allocate the object's space in the GPU's page tables.
|
|
* Inserting PTEs will happen later, but the offset is for the
|
|
* lifetime of the BO.
|
|
*/
|
|
ret = drm_mm_insert_node_generic(&v3d->mm, &bo->node,
|
|
obj->size >> V3D_MMU_PAGE_SHIFT,
|
|
GMP_GRANULARITY >> V3D_MMU_PAGE_SHIFT, 0, 0);
|
|
spin_unlock(&v3d->mm_lock);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Track stats for /debug/dri/n/bo_stats. */
|
|
mutex_lock(&v3d->bo_lock);
|
|
v3d->bo_stats.num_allocated++;
|
|
v3d->bo_stats.pages_allocated += obj->size >> V3D_MMU_PAGE_SHIFT;
|
|
mutex_unlock(&v3d->bo_lock);
|
|
|
|
v3d_mmu_insert_ptes(bo);
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct v3d_bo *v3d_bo_create(struct drm_device *dev, struct drm_file *file_priv,
|
|
size_t unaligned_size)
|
|
{
|
|
struct drm_gem_shmem_object *shmem_obj;
|
|
struct v3d_bo *bo;
|
|
int ret;
|
|
|
|
shmem_obj = drm_gem_shmem_create(dev, unaligned_size);
|
|
if (IS_ERR(shmem_obj))
|
|
return ERR_CAST(shmem_obj);
|
|
bo = to_v3d_bo(&shmem_obj->base);
|
|
bo->vaddr = NULL;
|
|
|
|
ret = v3d_bo_create_finish(&shmem_obj->base);
|
|
if (ret)
|
|
goto free_obj;
|
|
|
|
return bo;
|
|
|
|
free_obj:
|
|
drm_gem_shmem_free(shmem_obj);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
struct drm_gem_object *
|
|
v3d_prime_import_sg_table(struct drm_device *dev,
|
|
struct dma_buf_attachment *attach,
|
|
struct sg_table *sgt)
|
|
{
|
|
struct drm_gem_object *obj;
|
|
int ret;
|
|
|
|
obj = drm_gem_shmem_prime_import_sg_table(dev, attach, sgt);
|
|
if (IS_ERR(obj))
|
|
return obj;
|
|
|
|
ret = v3d_bo_create_finish(obj);
|
|
if (ret) {
|
|
drm_gem_shmem_free(&to_v3d_bo(obj)->base);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
return obj;
|
|
}
|
|
|
|
void v3d_get_bo_vaddr(struct v3d_bo *bo)
|
|
{
|
|
struct drm_gem_shmem_object *obj = &bo->base;
|
|
|
|
bo->vaddr = vmap(obj->pages, obj->base.size >> PAGE_SHIFT, VM_MAP,
|
|
pgprot_writecombine(PAGE_KERNEL));
|
|
}
|
|
|
|
void v3d_put_bo_vaddr(struct v3d_bo *bo)
|
|
{
|
|
vunmap(bo->vaddr);
|
|
bo->vaddr = NULL;
|
|
}
|
|
|
|
int v3d_create_bo_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file_priv)
|
|
{
|
|
struct drm_v3d_create_bo *args = data;
|
|
struct v3d_bo *bo = NULL;
|
|
int ret;
|
|
|
|
if (args->flags != 0) {
|
|
DRM_INFO("unknown create_bo flags: %d\n", args->flags);
|
|
return -EINVAL;
|
|
}
|
|
|
|
bo = v3d_bo_create(dev, file_priv, PAGE_ALIGN(args->size));
|
|
if (IS_ERR(bo))
|
|
return PTR_ERR(bo);
|
|
|
|
args->offset = bo->node.start << V3D_MMU_PAGE_SHIFT;
|
|
|
|
ret = drm_gem_handle_create(file_priv, &bo->base.base, &args->handle);
|
|
drm_gem_object_put(&bo->base.base);
|
|
|
|
return ret;
|
|
}
|
|
|
|
int v3d_mmap_bo_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file_priv)
|
|
{
|
|
struct drm_v3d_mmap_bo *args = data;
|
|
struct drm_gem_object *gem_obj;
|
|
|
|
if (args->flags != 0) {
|
|
DRM_INFO("unknown mmap_bo flags: %d\n", args->flags);
|
|
return -EINVAL;
|
|
}
|
|
|
|
gem_obj = drm_gem_object_lookup(file_priv, args->handle);
|
|
if (!gem_obj) {
|
|
DRM_DEBUG("Failed to look up GEM BO %d\n", args->handle);
|
|
return -ENOENT;
|
|
}
|
|
|
|
args->offset = drm_vma_node_offset_addr(&gem_obj->vma_node);
|
|
drm_gem_object_put(gem_obj);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int v3d_get_bo_offset_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file_priv)
|
|
{
|
|
struct drm_v3d_get_bo_offset *args = data;
|
|
struct drm_gem_object *gem_obj;
|
|
struct v3d_bo *bo;
|
|
|
|
gem_obj = drm_gem_object_lookup(file_priv, args->handle);
|
|
if (!gem_obj) {
|
|
DRM_DEBUG("Failed to look up GEM BO %d\n", args->handle);
|
|
return -ENOENT;
|
|
}
|
|
bo = to_v3d_bo(gem_obj);
|
|
|
|
args->offset = bo->node.start << V3D_MMU_PAGE_SHIFT;
|
|
|
|
drm_gem_object_put(gem_obj);
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
v3d_wait_bo_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file_priv)
|
|
{
|
|
int ret;
|
|
struct drm_v3d_wait_bo *args = data;
|
|
ktime_t start = ktime_get();
|
|
u64 delta_ns;
|
|
unsigned long timeout_jiffies =
|
|
nsecs_to_jiffies_timeout(args->timeout_ns);
|
|
|
|
if (args->pad != 0)
|
|
return -EINVAL;
|
|
|
|
ret = drm_gem_dma_resv_wait(file_priv, args->handle,
|
|
true, timeout_jiffies);
|
|
|
|
/* Decrement the user's timeout, in case we got interrupted
|
|
* such that the ioctl will be restarted.
|
|
*/
|
|
delta_ns = ktime_to_ns(ktime_sub(ktime_get(), start));
|
|
if (delta_ns < args->timeout_ns)
|
|
args->timeout_ns -= delta_ns;
|
|
else
|
|
args->timeout_ns = 0;
|
|
|
|
/* Asked to wait beyond the jiffie/scheduler precision? */
|
|
if (ret == -ETIME && args->timeout_ns)
|
|
ret = -EAGAIN;
|
|
|
|
return ret;
|
|
}
|