Sungwoo Kim
49d5867819
Bluetooth: L2CAP: Fix u8 overflow
...
[ Upstream commit bcd70260ef56e0aee8a4fc6cd214a419900b0765 ]
By keep sending L2CAP_CONF_REQ packets, chan->num_conf_rsp increases
multiple times and eventually it will wrap around the maximum number
(i.e., 255).
This patch prevents this by adding a boundary check with
L2CAP_MAX_CONF_RSP
Btmon log:
Bluetooth monitor ver 5.64
= Note: Linux version 6.1.0-rc2 (x86_64) 0.264594
= Note: Bluetooth subsystem version 2.22 0.264636
@ MGMT Open: btmon (privileged) version 1.22 {0x0001} 0.272191
= New Index: 00:00:00:00:00:00 (Primary,Virtual,hci0) [hci0] 13.877604
@ RAW Open: 9496 (privileged) version 2.22 {0x0002} 13.890741
= Open Index: 00:00:00:00:00:00 [hci0] 13.900426
(...)
> ACL Data RX: Handle 200 flags 0x00 dlen 1033 #32 [hci0] 14.273106
invalid packet size (12 != 1033)
08 00 01 00 02 01 04 00 01 10 ff ff ............
> ACL Data RX: Handle 200 flags 0x00 dlen 1547 #33 [hci0] 14.273561
invalid packet size (14 != 1547)
0a 00 01 00 04 01 06 00 40 00 00 00 00 00 ........@.....
> ACL Data RX: Handle 200 flags 0x00 dlen 2061 #34 [hci0] 14.274390
invalid packet size (16 != 2061)
0c 00 01 00 04 01 08 00 40 00 00 00 00 00 00 04 ........@.......
> ACL Data RX: Handle 200 flags 0x00 dlen 2061 #35 [hci0] 14.274932
invalid packet size (16 != 2061)
0c 00 01 00 04 01 08 00 40 00 00 00 07 00 03 00 ........@.......
= bluetoothd: Bluetooth daemon 5.43 14.401828
> ACL Data RX: Handle 200 flags 0x00 dlen 1033 #36 [hci0] 14.275753
invalid packet size (12 != 1033)
08 00 01 00 04 01 04 00 40 00 00 00 ........@...
Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-01-07 12:07:11 +01:00
..
2020-01-29 10:24:22 +01:00
2022-12-08 11:15:41 +01:00
2021-08-04 11:58:02 +02:00
2020-01-12 11:24:27 +01:00
2021-04-07 12:05:39 +02:00
2022-11-03 23:49:15 +09:00
2022-03-16 12:49:00 +01:00
2022-03-16 12:49:01 +01:00
2023-01-07 12:07:11 +01:00
2022-09-15 12:39:46 +02:00
2022-11-25 17:35:39 +01:00
2022-10-26 13:15:46 +02:00
2020-11-10 10:23:59 +01:00
2022-11-25 17:35:35 +01:00
2022-03-08 19:00:59 +01:00
2021-09-22 11:43:09 +02:00
2021-07-28 09:14:27 +02:00
2018-07-22 14:27:39 +02:00
2020-04-13 10:32:53 +02:00
2020-01-12 11:24:19 +01:00
2022-12-08 11:15:41 +01:00
2022-11-03 23:49:17 +09:00
2022-12-08 11:15:40 +01:00
2022-12-08 11:15:42 +01:00
2018-09-15 09:43:01 +02:00
2020-12-11 13:37:56 +01:00
2022-11-25 17:35:42 +01:00
2022-12-08 11:15:39 +01:00
2022-06-25 11:45:19 +02:00
2021-02-10 09:09:25 +01:00
2022-03-28 08:06:06 +02:00
2022-12-08 11:15:39 +01:00
2022-12-14 11:24:34 +01:00
2021-03-17 16:10:13 +01:00
2021-01-12 19:49:01 +01:00
2022-11-10 15:46:05 +01:00
2022-01-27 08:47:42 +01:00
2022-05-18 09:15:43 +02:00
2021-07-28 09:14:27 +02:00
2022-12-14 11:24:34 +01:00
2022-11-03 23:49:19 +09:00
2022-12-08 11:15:41 +01:00
2022-01-11 13:38:12 +01:00
2021-03-30 14:41:42 +02:00
2022-10-26 13:15:40 +02:00
2020-01-12 11:24:23 +01:00
2022-11-10 15:46:05 +01:00
2022-06-14 16:52:33 +02:00
2022-11-10 15:46:05 +01:00
2022-06-14 16:52:32 +02:00
2018-04-29 11:32:02 +02:00
2022-09-15 12:39:46 +02:00
2022-12-14 11:24:35 +01:00
2022-01-27 08:47:41 +01:00
2022-08-25 11:09:29 +02:00
2022-09-15 12:39:44 +02:00
2022-11-25 17:35:40 +01:00
2022-10-26 13:15:45 +02:00
2021-06-30 08:49:12 -04:00
2021-08-04 11:58:01 +02:00
2022-09-05 10:23:55 +02:00