00085f1efa
The dma-mapping core and the implementations do not change the DMA attributes passed by pointer. Thus the pointer can point to const data. However the attributes do not have to be a bitfield. Instead unsigned long will do fine: 1. This is just simpler. Both in terms of reading the code and setting attributes. Instead of initializing local attributes on the stack and passing pointer to it to dma_set_attr(), just set the bits. 2. It brings safeness and checking for const correctness because the attributes are passed by value. Semantic patches for this change (at least most of them): virtual patch virtual context @r@ identifier f, attrs; @@ f(..., - struct dma_attrs *attrs + unsigned long attrs , ...) { ... } @@ identifier r.f; @@ f(..., - NULL + 0 ) and // Options: --all-includes virtual patch virtual context @r@ identifier f, attrs; type t; @@ t f(..., struct dma_attrs *attrs); @@ identifier r.f; @@ f(..., - NULL + 0 ) Link: http://lkml.kernel.org/r/1468399300-5399-2-git-send-email-k.kozlowski@samsung.com Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Acked-by: Vineet Gupta <vgupta@synopsys.com> Acked-by: Robin Murphy <robin.murphy@arm.com> Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> Acked-by: Mark Salter <msalter@redhat.com> [c6x] Acked-by: Jesper Nilsson <jesper.nilsson@axis.com> [cris] Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> [drm] Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> Acked-by: Joerg Roedel <jroedel@suse.de> [iommu] Acked-by: Fabien Dessenne <fabien.dessenne@st.com> [bdisp] Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> [vb2-core] Acked-by: David Vrabel <david.vrabel@citrix.com> [xen] Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> [xen swiotlb] Acked-by: Joerg Roedel <jroedel@suse.de> [iommu] Acked-by: Richard Kuo <rkuo@codeaurora.org> [hexagon] Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> [m68k] Acked-by: Gerald Schaefer <gerald.schaefer@de.ibm.com> [s390] Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> [avr32] Acked-by: Vineet Gupta <vgupta@synopsys.com> [arc] Acked-by: Robin Murphy <robin.murphy@arm.com> [arm64 and dma-iommu] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
---|---|---|
.. | ||
.gitignore | ||
alpha_ksyms.c | ||
asm-offsets.c | ||
audit.c | ||
binfmt_loader.c | ||
console.c | ||
core_apecs.c | ||
core_cia.c | ||
core_irongate.c | ||
core_lca.c | ||
core_marvel.c | ||
core_mcpcia.c | ||
core_polaris.c | ||
core_t2.c | ||
core_titan.c | ||
core_tsunami.c | ||
core_wildfire.c | ||
entry.S | ||
err_common.c | ||
err_ev6.c | ||
err_ev7.c | ||
err_impl.h | ||
err_marvel.c | ||
err_titan.c | ||
es1888.c | ||
gct.c | ||
head.S | ||
io.c | ||
irq_alpha.c | ||
irq_i8259.c | ||
irq_impl.h | ||
irq_pyxis.c | ||
irq_srm.c | ||
irq.c | ||
machvec_impl.h | ||
Makefile | ||
module.c | ||
osf_sys.c | ||
pc873xx.c | ||
pc873xx.h | ||
pci_impl.h | ||
pci_iommu.c | ||
pci-noop.c | ||
pci-sysfs.c | ||
pci.c | ||
perf_event.c | ||
process.c | ||
proto.h | ||
ptrace.c | ||
rtc.c | ||
setup.c | ||
signal.c | ||
smc37c93x.c | ||
smc37c669.c | ||
smp.c | ||
srm_env.c | ||
srmcons.c | ||
sys_alcor.c | ||
sys_cabriolet.c | ||
sys_dp264.c | ||
sys_eb64p.c | ||
sys_eiger.c | ||
sys_jensen.c | ||
sys_marvel.c | ||
sys_miata.c | ||
sys_mikasa.c | ||
sys_nautilus.c | ||
sys_noritake.c | ||
sys_rawhide.c | ||
sys_ruffian.c | ||
sys_rx164.c | ||
sys_sable.c | ||
sys_sio.c | ||
sys_sx164.c | ||
sys_takara.c | ||
sys_titan.c | ||
sys_wildfire.c | ||
systbls.S | ||
time.c | ||
traps.c | ||
vmlinux.lds.S |