Jon Maxwell 0048369055 tcp: Add mark for TIMEWAIT sockets
This version has some suggestions by Eric Dumazet:

- Use a local variable for the mark in IPv6 instead of ctl_sk to avoid SMP
races.
- Use the more elegant "IP4_REPLY_MARK(net, skb->mark) ?: sk->sk_mark"
statement.
- Factorize code as sk_fullsock() check is not necessary.

Aidan McGurn from Openwave Mobility systems reported the following bug:

"Marked routing is broken on customer deployment. Its effects are large
increase in Uplink retransmissions caused by the client never receiving
the final ACK to their FINACK - this ACK misses the mark and routes out
of the incorrect route."

Currently marks are added to sk_buffs for replies when the "fwmark_reflect"
sysctl is enabled. But not for TW sockets that had sk->sk_mark set via
setsockopt(SO_MARK..).

Fix this in IPv4/v6 by adding tw->tw_mark for TIME_WAIT sockets. Copy the the
original sk->sk_mark in __inet_twsk_hashdance() to the new tw->tw_mark location.
Then progate this so that the skb gets sent with the correct mark. Do the same
for resets. Give the "fwmark_reflect" sysctl precedence over sk->sk_mark so that
netfilter rules are still honored.

Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-05-10 17:44:52 -04:00
..
2018-03-27 13:18:09 -04:00
2018-03-27 13:18:09 -04:00
2018-04-19 15:40:13 -04:00
2017-05-21 13:42:36 -04:00
2018-03-27 13:18:09 -04:00
2018-05-07 23:50:27 -04:00
2018-04-26 15:07:42 -04:00
2018-05-01 09:38:41 +02:00
2018-04-23 10:21:24 -04:00
2018-02-28 11:43:28 -05:00
2018-03-27 13:18:09 -04:00
2016-12-25 17:21:23 +01:00
2018-03-27 13:18:09 -04:00
2017-09-01 18:35:23 -07:00
2018-03-27 13:18:09 -04:00
2018-05-10 17:44:52 -04:00
2018-03-27 13:18:09 -04:00