012715ad7c
mtk_clk_register_ref2usb_tx() prints an error message if clk_register() fails. It doesn't if kzalloc() fails though. The caller would then tack on its own error message to handle this. Also, All other clk registration functions in the MediaTek clk library leave the error message printing to the bulk registration functions, while the helpers that register individual clks just return error codes. Drop the error message that is printed when clk_register() fails in mtk_clk_register_ref2usb_tx() to make its behavior consistent both across its failure modes, and with the rest of the driver library. Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Miles Chen <miles.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Tested-by: Miles Chen <miles.chen@mediatek.com> Link: https://lore.kernel.org/r/20220519071610.423372-3-wenst@chromium.org Signed-off-by: Stephen Boyd <sboyd@kernel.org>
101 lines
2.1 KiB
C
101 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2015 MediaTek Inc.
|
|
* Author: James Liao <jamesjj.liao@mediatek.com>
|
|
*/
|
|
|
|
#include <linux/delay.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include "clk-mtk.h"
|
|
|
|
#define REF2USB_TX_EN BIT(0)
|
|
#define REF2USB_TX_LPF_EN BIT(1)
|
|
#define REF2USB_TX_OUT_EN BIT(2)
|
|
#define REF2USB_EN_MASK (REF2USB_TX_EN | REF2USB_TX_LPF_EN | \
|
|
REF2USB_TX_OUT_EN)
|
|
|
|
struct mtk_ref2usb_tx {
|
|
struct clk_hw hw;
|
|
void __iomem *base_addr;
|
|
};
|
|
|
|
static inline struct mtk_ref2usb_tx *to_mtk_ref2usb_tx(struct clk_hw *hw)
|
|
{
|
|
return container_of(hw, struct mtk_ref2usb_tx, hw);
|
|
}
|
|
|
|
static int mtk_ref2usb_tx_is_prepared(struct clk_hw *hw)
|
|
{
|
|
struct mtk_ref2usb_tx *tx = to_mtk_ref2usb_tx(hw);
|
|
|
|
return (readl(tx->base_addr) & REF2USB_EN_MASK) == REF2USB_EN_MASK;
|
|
}
|
|
|
|
static int mtk_ref2usb_tx_prepare(struct clk_hw *hw)
|
|
{
|
|
struct mtk_ref2usb_tx *tx = to_mtk_ref2usb_tx(hw);
|
|
u32 val;
|
|
|
|
val = readl(tx->base_addr);
|
|
|
|
val |= REF2USB_TX_EN;
|
|
writel(val, tx->base_addr);
|
|
udelay(100);
|
|
|
|
val |= REF2USB_TX_LPF_EN;
|
|
writel(val, tx->base_addr);
|
|
|
|
val |= REF2USB_TX_OUT_EN;
|
|
writel(val, tx->base_addr);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void mtk_ref2usb_tx_unprepare(struct clk_hw *hw)
|
|
{
|
|
struct mtk_ref2usb_tx *tx = to_mtk_ref2usb_tx(hw);
|
|
u32 val;
|
|
|
|
val = readl(tx->base_addr);
|
|
val &= ~REF2USB_EN_MASK;
|
|
writel(val, tx->base_addr);
|
|
}
|
|
|
|
static const struct clk_ops mtk_ref2usb_tx_ops = {
|
|
.is_prepared = mtk_ref2usb_tx_is_prepared,
|
|
.prepare = mtk_ref2usb_tx_prepare,
|
|
.unprepare = mtk_ref2usb_tx_unprepare,
|
|
};
|
|
|
|
struct clk * __init mtk_clk_register_ref2usb_tx(const char *name,
|
|
const char *parent_name, void __iomem *reg)
|
|
{
|
|
struct mtk_ref2usb_tx *tx;
|
|
struct clk_init_data init = {};
|
|
struct clk *clk;
|
|
|
|
tx = kzalloc(sizeof(*tx), GFP_KERNEL);
|
|
if (!tx)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
tx->base_addr = reg;
|
|
tx->hw.init = &init;
|
|
|
|
init.name = name;
|
|
init.ops = &mtk_ref2usb_tx_ops;
|
|
init.parent_names = &parent_name;
|
|
init.num_parents = 1;
|
|
|
|
clk = clk_register(NULL, &tx->hw);
|
|
|
|
if (IS_ERR(clk))
|
|
kfree(tx);
|
|
|
|
return clk;
|
|
}
|
|
|
|
MODULE_LICENSE("GPL");
|